add rule provide-print-css - #22
Merged
utarwyn merged 5 commits intoSep 10, 2023
Merged
Conversation
utarwyn
requested changes
Aug 6, 2023
utarwyn
left a comment
Member
There was a problem hiding this comment.
Thank you for this rule too! 💯
elisecodedestrucs
force-pushed
the
no-missing-print-css
branch
3 times, most recently
from
August 10, 2023 08:28
ed933c6 to
c01564d
Compare
elisecodedestrucs
force-pushed
the
no-missing-print-css
branch
from
August 10, 2023 08:35
c01564d to
879b870
Compare
utarwyn
reviewed
Aug 16, 2023
utarwyn
left a comment
Member
There was a problem hiding this comment.
This looks good to me! 💯
But one more thing: @elisecodedestrucs does this rule also raise a warning in files that contain sub-components (e.g. just the menu, navbar, footer, etc.)? I don't think any warnings should be raised except in the JSX containing the header (with head/meta tags)
# Conflicts: # CHANGELOG.md
utarwyn
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this rule aims to reming the developper to privide a print css to allow a more efficient and economical print