Repository navigation
[3.10.x] Convert paths for MSYS2 and jvm.config placeholders in bin/mvn - #12567
Merged
Merged
Conversation
Backport of #12546 to the 3.10.x branch. Adapted for the different script location (src/bin/mvn vs src/assembly/maven/bin/mvn) and the simpler jvm.config handling (no JvmConfigParser on this branch). Key changes: - Detect MSYS2 (MSYS_NT-*) alongside MinGW in uname matching - Guard against missing cygpath(1) — warn and fall back to POSIX paths - Convert all paths (MAVEN_HOME, CLASSWORLDS_JAR, MAVEN_PROJECTBASEDIR, jline-native) for both Cygwin and MinGW/MSYS2, not just Cygwin - Convert jline-native path separately to avoid mixed separators - Use printf instead of echo for values holding paths (avoid backslash expansion in dash/ash) - Add shell test covering Cygwin, MinGW, MSYS2, and missing-cygpath fallback, wired into the build via exec-maven-plugin Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
commented
Jul 28, 2026
gnodet
left a comment
Contributor
Author
There was a problem hiding this comment.
LGTM — clean backport of #12546 (merged on master) to maven-3.10.x. Well-adapted for the branch differences: different script location (src/bin/mvn vs src/assembly/maven/bin/mvn) and no JvmConfigParser on this branch. The core improvements are all present: MSYS2 detection, cygpath guard with fallback, printf-over-echo for Windows paths, and comprehensive test script. The test script also includes the macOS $TMPDIR normalization fix from the follow-up commit.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of gnodet
Contributor
|
@gnodet Please assign appropriate label to PR according to the type of change. |
4 tasks done
1 task done
This was referenced Oct 13, 2026
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 14, 2026
Port of apache#13429 to `master`. A cygpath(1) from an unrelated POSIX emulation layer (e.g. Anaconda) can be found on the PATH first. It re-roots every POSIX path under its own prefix, causing a bare ClassNotFoundException at launch. This adds a sanity-probe: convert the current directory with the cygpath found, and require its Windows form to exist on disk. On failure, warn and fall back to POSIX paths — same posture as the missing-cygpath case introduced in apache#12567. - Add cygpath sanity-check: verify the Windows path returned by cygpath exists on disk - On failure, warn and fall back to POSIX paths - Add test coverage in test-mvn-path-conversion.sh for the bogus-cygpath scenario - Revert unrelated ProjectModelResolverTest changes that were on the branch
gnodet
added a commit
that referenced
this pull request
Oct 14, 2026
Port of #13429 to `master`. A `cygpath(1)` from an unrelated POSIX emulation layer (e.g. Anaconda) can be found on the PATH first. It re-roots every POSIX path under its own prefix, causing a bare `ClassNotFoundException` at launch. This adds a sanity-probe: convert the current directory with the `cygpath` found, and require its Windows form to exist on disk. On failure, warn and fall back to POSIX paths — same posture as the missing-cygpath case introduced in #12567. - Add cygpath sanity-check: verify the Windows path returned by cygpath exists on disk - On failure, warn and fall back to POSIX paths - Add test coverage in `test-mvn-path-conversion.sh` for the bogus-cygpath scenario Closes #13414
gnodet
added a commit
that referenced
this pull request
Oct 14, 2026
Port of #13429 to `maven-4.0.x`. A `cygpath(1)` from an unrelated POSIX emulation layer (e.g. Anaconda) can be found on the PATH first. It re-roots every POSIX path under its own prefix, causing a bare `ClassNotFoundException` at launch. This adds a sanity-probe: convert the current directory with the `cygpath` found, and require its Windows form to exist on disk. On failure, warn and fall back to POSIX paths — same posture as the missing-cygpath case introduced in #12567. - Add cygpath sanity-check: verify the Windows path returned by cygpath exists on disk - On failure, warn and fall back to POSIX paths - Add test coverage in `test-mvn-path-conversion.sh` for the bogus-cygpath scenario Closes #13414
gnodet
added a commit
to choksi2212/maven
that referenced
this pull request
Oct 14, 2026
- Add cygpath sanity-check: convert the current directory and require its Windows form to exist on disk before trusting the cygpath binary - On failure, warn (naming the offending cygpath and the non-existing Windows form it produced) and fall back to POSIX paths — same posture as the missing-cygpath case introduced in apache#12567 - Use printf for the warning message so backslashes survive dash/sh - Add test coverage in test-mvn-path-conversion.sh: 6 new assertions for the bogus-cygpath scenario (foreign cygpath falls back to POSIX paths, warning names the binary and shows the bad conversion) Fixes apache#13414
gnodet
pushed a commit
that referenced
this pull request
Oct 14, 2026
- Add cygpath sanity-check: convert the current directory and require its Windows form to exist on disk before trusting the cygpath binary - On failure, warn (naming the offending cygpath and the non-existing Windows form it produced) and fall back to POSIX paths — same posture as the missing-cygpath case introduced in #12567 - Use printf for the warning message so backslashes survive dash/sh - Add test coverage in test-mvn-path-conversion.sh: 6 new assertions for the bogus-cygpath scenario (foreign cygpath falls back to POSIX paths, warning names the binary and shows the bad conversion) Fixes #13414
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #12546 to the
maven-3.10.xbranch, adapted for the different script location (src/bin/mvnvssrc/assembly/maven/bin/mvn) and the simpler jvm.config handling (noJvmConfigParseron this branch).MSYS_NT-*) alongside MinGW inunamematchingcygpath(1)— warn and fall back to POSIX pathsMAVEN_HOME,CLASSWORLDS_JAR,MAVEN_PROJECTBASEDIR, jline-native) for both Cygwin and MinGW/MSYS2, not just CygwinC:\maven/lib/jline-native)printfinstead ofechofor values holding paths (avoid backslash expansion in dash/ash)exec-maven-pluginTest plan
🤖 Generated with Claude Code