Repository navigation
Migrate the embedder-test-project fixture to JUnit 5 - #12717
Merged
Merged
Conversation
The embedder-test-project sample under maven-embedder/src/test is a standalone, un-parented fixture project (own groupId/artifactId/version) used as filesystem input data. It is not part of the reactor and no test code references it, so nothing in the build compiles or runs it. Convert its archetype-generated AppTest from JUnit 3.8.1 to JUnit 5 Jupiter and bump its pinned surefire-plugin from 2.4.3 so the fixture still builds and runs standalone if invoked by hand. Other fixture projects under maven-embedder/src/test and maven-core/src/test still declare junit:junit; this commit does not touch them. Generated-by: Claude Opus 5 (1M context)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
embedder-test-projectsample undermaven-embedder/src/testis a standalone, un-parented fixture project (its own groupId/artifactId/version) that exists as filesystem input data. It is not part of the reactor and no test code references it, so nothing in the build compiles or runs it.This converts its archetype-generated
AppTestfrom JUnit 3.8.1 to JUnit 5 Jupiter and bumps its pinned surefire-plugin from 2.4.3, so the fixture still builds and runs standalone if someone invokes it by hand.Scope, stated plainly: this is deliberately narrow. Roughly 20 other fixture projects under
maven-embedder/src/testandmaven-core/src/teststill declarejunit:junit, andmaven-compatstill has real JUnit 4 test code. This PR does not touch any of them. If the preference is to do the fixtures in one sweep rather than piecemeal, say so and I will fold this into a single change instead.maven-embedder/src/testno longer exists onmaster, so this applies to the 3.x line only.