Skip to content

Add additional condition for assertEqualsNoOrder - #2723

Merged
krmahadevan merged 5 commits into
testng-team:masterfrom
Dymitriux:assertEqualdNoOrder-additional-condition
Jan 31, 2022
Merged

krmahadevan merged 5 commits into
testng-team:masterfrom
Dymitriux:assertEqualdNoOrder-additional-condition

Conversation

@Dymitriux

@Dymitriux Dymitriux commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

Add additional condition for assertEqualsNoOrder collection and iterators to check also size

Fixes # .

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

@juherr juherr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for the change but the issue was not detected before by a test.
Could you add one?

@Dymitriux

Copy link
Copy Markdown
Contributor Author

Tests added.

@krmahadevan
krmahadevan self-requested a review January 31, 2022 06:20

@krmahadevan krmahadevan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dymitriux - We have failures in tests due to formatting failures.
Please do the following:

  1. From the command prompt run ./gradlew autostyleApply
  2. Update this PR with the new changes (the above command will automatically apply formatting changes)
  3. Run ./gradlew check and ensure that there are no failures.
  4. Push and let me know once done.

For more details please refer to https://github.com/cbeust/testng/blob/master/.github/CONTRIBUTING.md

@Dymitriux

Copy link
Copy Markdown
Contributor Author

@krmahadevan Formatting changes pushed, sorry for that, forgot about autoStyleApply after adding test cases, now it should be ok.

@krmahadevan
krmahadevan self-requested a review January 31, 2022 09:47
@krmahadevan
krmahadevan merged commit 331bfbe into testng-team:master Jan 31, 2022
@krmahadevan

Copy link
Copy Markdown
Member

@Dymitriux - Thanks for taking the time with raising this PR. This is now merged.

@Dymitriux
Dymitriux deleted the assertEqualdNoOrder-additional-condition branch January 31, 2022 19:32
@Dymitriux

Copy link
Copy Markdown
Contributor Author

@krmahadevan No problem, hope I will find more time for contribution. I will look into issues marked with milestone 7.6.0

@krmahadevan

Copy link
Copy Markdown
Member

@Dymitriux that would be awesome! Looking forward to more contributions from you.

@juherr juherr added this to the 7.6.0 milestone Sep 7, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants