Add additional condition for assertEqualsNoOrder - #2723
krmahadevan merged 5 commits into
Conversation
juherr
left a comment
There was a problem hiding this comment.
Ok for the change but the issue was not detected before by a test.
Could you add one?
|
Tests added. |
There was a problem hiding this comment.
@Dymitriux - We have failures in tests due to formatting failures.
Please do the following:
- From the command prompt run
./gradlew autostyleApply - Update this PR with the new changes (the above command will automatically apply formatting changes)
- Run
./gradlew checkand ensure that there are no failures. - Push and let me know once done.
For more details please refer to https://github.com/cbeust/testng/blob/master/.github/CONTRIBUTING.md
|
@krmahadevan Formatting changes pushed, sorry for that, forgot about autoStyleApply after adding test cases, now it should be ok. |
|
@Dymitriux - Thanks for taking the time with raising this PR. This is now merged. |
|
@krmahadevan No problem, hope I will find more time for contribution. I will look into issues marked with milestone 7.6.0 |
|
@Dymitriux that would be awesome! Looking forward to more contributions from you. |
Add additional condition for assertEqualsNoOrder collection and iterators to check also size
Fixes # .
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.