Unexpected test runs count with retry analyzer

[krmahadevan]

Closes #2798

Fixes #2798 .

Did you remember to?

• Add test case(s)
• Update CHANGES.txt
• Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

• Add new features to TestNG (or)
• Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

[juherr]

I don't catch what is the fix because it looks just like a refactor (which is good btw).
Did you reproduce the issue?

[krmahadevan]

I don't catch what is the fix because it looks just like a refactor (which is good btw). Did you reproduce the issue?

Yes I have reproduced the problem and only after this change the problem goes away.
The issue is that the object instantiation is NOT atomic in nature. So we should have been using either a synchronized() keyword (or) we should have used a Function so that the Map implementation guarantees the atomicity.

[krmahadevan]

Earlier the get() and put() are not atomic in nature.