fix: file:// loader entry and node-level TLS detection in mtls - #231
Conversation
F35: loader resolved `file://` entry URLs as plain paths, mangling them into `$cwd/file:/...` and yielding notFound. Check the `file://` scheme first and only `resolve()` plain filesystem paths. F37: mtls plugin only accepted cert/key via `tls.cert/key`, throwing a false "requires an HTTPS server" error when cert/key were supplied via node server options. Mirror the node adapter and accept both paths. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
file:// loader entry and node-level TLS detection in mtls
Two small Node-scope fixes:
src/loader.ts): afile://URL entry was passed throughresolve()as a plain path, mangling it into$cwd/file:/...and returningnotFound. Now thefile://scheme is checked first and only plain filesystem paths areresolve()d.src/mtls.ts): the plugin only accepted TLS viatls.cert/tls.keyand threw a false "requires an HTTPS server" error when cert/key were supplied through node server options. Detection now mirrors the node adapter and accepts cert/key from either path.Tests extended for both cases;
build,vitest,lint, andtypecheckpass.🤖 Generated with Claude Code