Conversation
There was a problem hiding this comment.
✅ Ready to approve
The change is a minimal, verified parity fix with the Terraform plugin and directly addresses the reported missing NeedsAuth rule.
Note: this review does not count toward required approvals for merging.
Pull request overview
Aligns the OpenTofu plugin’s authentication triggering behavior with the Terraform plugin by ensuring tofu workspace … subcommands prompt for credential injection when appropriate (fixing #618).
Changes:
- Added
needsauth.ForCommand("workspace")to the OpenTofu plugin’sNeedsAuthrules so workspace operations trigger auth/credential injection.
File summaries
| File | Description |
|---|---|
| plugins/tofu/terraform.go | Adds workspace to the auth-gated subcommands list, matching the Terraform plugin behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Closing as changes have already been fixed in https://github.com/1Password/shell-plugins/pull/666/changes |
Summary
Adds
workspaceto the list of subcommands requiring authentication in the OpenTofu plugin (plugins/tofu/terraform.go).Previously, running commands like
tofu workspace selectortofu workspace listdid not trigger credential injection.Fixes #618