Fix response body accessors for bodyless and rebuilt responses - #2329
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
ResponseBuilder#build()hands out the list it accumulates into, andAsyncCompletionHandlerresets that builder on everyonStatusReceived. A handler reused for a second request empties the first response and refills it with thesecond body.
NettyResponse#getResponseBodyAsByteBuf()sizes a composite to the part count, andCompositeByteBufrejects zero components, so a bodyless response throws instead of returning an empty buffer.The body view added in #2322 names three of the four holders of its array, and its
NettyResponseoverride replaced the inherited description, dropping the read-only warning from the only published implementation.Modification:
Copy the parts in
build(), floor the composite at one component, namegetBodyByteBuffer()as the fourth holder, and restore the inherited text with{@inheritDoc}.Result:
A response keeps its own body when its builder is reused, a bodyless response yields an empty buffer, and the view names every holder it has.