Reject fully qualified names and wildcard imports - #2338
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Nothing enforced import hygiene, so fully qualified class names and wildcard imports had accumulated across main and test sources. JDK 11 also caps Error Prone at 2.31.0, and newer JDKs were silently inheriting that cap.
Modification:
Turn on Error Prone's
UnnecessarilyFullyQualifiedandWildcardImportas errors. Test sources compile with only those two checks, keeping NullAway off there. Replace the fully qualified names already in the tree with imports and expand the wildcard imports.Raise Error Prone to 2.42.0 on JDK 17 and 2.50.0 on JDK 21+, ignore both it and NullAway in Dependabot since a minor bump drops JDK 11, and add a JDK 21 static analysis step to
compile-and-check.Result:
Fully qualified class names and wildcard imports fail the build on every JDK, and CI runs a maintained Error Prone on newer JDKs.