Repository navigation
Detect transport of external event loop group by IoHandler - #2340
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
ChannelManageridentified a user-suppliedEventLoopGroupby its class. Since Netty 4.2 every group is aMultiThreadIoEventLoopGroupparameterized with anIoHandler, so a group built the idiomatic way was rejected with "Unknown event loop group". io_uring never had a group class of its own, so it could not be supplied at all. See #2121.Modification:
Ask the group which
IoHandlerit runs, viaIoEventLoopGroup#isIoType, instead of checking its class. Handler classes are still resolved by name, because the native transports are optional dependencies.Result:
Fixes #2121