Conversation
gavande1
reviewed
Aug 27, 2026
gavande1
reviewed
Aug 27, 2026
Contributor
|
Thanks, @atirna, for addressing the feedback. I will take a look shortly. |
Contributor
|
@wojtekn, do you have a few minutes to take a look at this one too? Would love your eyes on it. |
gavande1
reviewed
Sep 3, 2026
Author
|
good call, done. building it conditionally keeps the object literal typed, so
|
constant_exists, constant_equals and define_constant each walked the token array looking for the same call.
…type Spreading the defaults and deleting DB_NAME afterwards required a Record<string, boolean | string>, which dropped the compile-time check that WP_DEBUG_LOG and WP_DEBUG_DISPLAY stay boolean.
atirna
force-pushed
the
fix/preserve-external-mysql-db-name
branch
from
September 17, 2026 02:55
51bb9c1 to
4a1e472
Compare
|
Hi @gavande1 — any news on this one ? The last review comment looks addressed. Is there a chance it lands in 1.23 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Used AI assistance while investigating and implementing this fix. I reviewed and own the patch.
Proposed Changes
DB_NAME.DB_NAMEtowordpressfor SQLite sites, including empty, dynamic, or duplicate definitions.DB_NAMEdefinitions untouched for external MySQL sites.Testing Instructions
npm test -- apps/cli/lib/native-php/tests/site-setup.test.ts(10 passed)npx prettier --check apps/cli/lib/native-php/site-setup.ts apps/cli/lib/native-php/tests/site-setup.test.ts apps/cli/lib/import-export/import/importers/importer.tsnpx eslint apps/cli/lib/native-php/site-setup.ts apps/cli/lib/native-php/tests/site-setup.test.ts apps/cli/lib/import-export/import/importers/importer.ts apps/cli/php/wp-config-transformer.phpphp -l apps/cli/php/wp-config-transformer.phpPre-merge Checklist