Skip to content

✨ Editor/Terminal Color Themes #189

Description

@austincondiff

Let's create our own set of pre-bundled themes.

  • We can provide similar ones to what Xcode comes with along with a few of our own.
  • Each theme will have the option to have a light mode and a dark mode that can optionally change when the user switches light/dark mode.
  • We will have a setting to use the themes background, or use the standard window background which is tinted by your wallpaper.
  • We can also provide "smart themes" which generate a theme based on the users tint color (See ✨ Automatically Generated Color Themes based on window tint color #46)
  • We might leverage some work being done in 👀 Extension Architecture / API #76.

Related issue #187.

Questions

  • Will themes each be extensions like in VSCode or will they be separate from themes in some way?

Activity

  1. underthestars-zhy commented on Mar 23, 2022

    @underthestars-zhy

    We could create a theme standard. And people can add their theme. It should be separated from the extension

  2. Jeehut commented on Mar 27, 2022

    @Jeehut
    Contributor

    I like the idea of adding color themes for syntax highlighting. But I think "smart themes" based on wallpaper background or tint color should be the second or third step. First, we should provide a decent set of popular theming styles, including some that have really good contrast for accessibility. Next, we should build a custom theme editor so users can duplicate the existing and adjust them to their needs. After that, we could make them export- and importable (e.g. as JSON files).

    Also, the default theming style should be one that's popular and that has a good contrast. The current one is actually quite hard to read, I also don't like the color style (which is subjective, but I'm using the default anywhere else so I'm not very demanding), see here for example:
    Screenshot 2022-03-27 at 14 51 55

  3. changed the title [-]Syntax Highlighting Themes[/-] [+][FEAT] - Custom Theming[/+] on Mar 31, 2022
  4. changed the title [-][FEAT] - Custom Theming[/-] [+]✨ Custom Theming[/+] on Mar 31, 2022
  5. added
    wontfixThis will not be worked on
    and removed
    wontfixThis will not be worked on
    on May 30, 2022
  6. deleted a comment from stale on Jun 1, 2022
  7. deleted a comment from stale on Aug 1, 2022
  8. removed
    wontfixThis will not be worked on
    on Aug 1, 2022
  9. changed the title [-]✨ Custom Theming[/-] [+]✨ Editor/Terminal Color Themes[/+] on Sep 28, 2022
  10. moved this from 🏁 Complete to 🏃‍♂️ In Progress in CodeEdit Projecton Feb 14, 2023
  11. austincondiff commented on Mar 4, 2023

    @austincondiff
    CollaboratorAuthor

    @CodeEditApp/admins what do we want to do with this issue? We have some themes, could we create new issues for future work?

  12. iggy890 commented on Mar 6, 2023

    @iggy890
    Contributor

    This seems like an issue that is hard to fix, SwiftTerm which is the package we're using is no longer receiving updates. We should either create a fork of SwiftTerm and edit that fork or change package.

  13. matthijseikelenboom commented on Mar 6, 2023

    @matthijseikelenboom
    Contributor

    What makes you say that the project isn't receiving updates anymore? The latest commit was 4 days ago?

  14. moved this from 🏃‍♂️ In Progress to 🏁 Complete in CodeEdit Projecton Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions