Cleanup how we allocate context-store ids by mcculls · Pull Request #12752 · DataDog/dd-trace-java

mcculls · 2026-10-05T21:25:44Z

Motivation

allocation now synchronizes on allocationLock instead of the ConcurrentHashMap itself
nextStoreId replaces STORES_BY_NAME.size() as the source of the next id
stores array grows by chunks of 16 elements, while still only allocating a store when necessary
logging now happens outside of the lock

Contributor Checklist

Format the title according to the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any other useful labels
Avoid using close, fix, or any linking keywords when referencing an issue
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, migration, or deletion
Update public documentation with any new configuration flags or behaviors
Once approved, use merge queue to merge the PR

Jira ticket: [PROJ-IDENT]

dd-octo-sts · 2026-10-05T21:45:58Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.95 s	13.84 s	[+0.1%; +1.5%] (maybe worse)
startup:insecure-bank:tracing:Agent	12.79 s	12.87 s	[-1.2%; -0.0%] (maybe better)
startup:petclinic:appsec:Agent	17.14 s	17.03 s	[-0.2%; +1.5%] (no difference)
startup:petclinic:iast:Agent	16.96 s	16.87 s	[-0.2%; +1.3%] (no difference)
startup:petclinic:profiling:Agent	16.37 s	16.70 s	[-3.0%; -1.0%] (significantly better)
startup:petclinic:sca:Agent	16.99 s	16.90 s	[-0.3%; +1.4%] (no difference)
startup:petclinic:tracing:Agent	15.99 s	16.13 s	[-1.9%; +0.2%] (no difference)

Commit: fb6292c2 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

chatgpt-codex-connector · 2026-10-05T22:16:39Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-05T22:19:03.192277Z	`e78675c`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

sarahchen6

Nice!

datadog-datadog-prod-us1-2

More details

The allocator preserves unique, contiguous context-store IDs under concurrent requests and publishes each store before returning its ID.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit e78675c · @DataDog review to ask questions}

PerfectSlayer

👏 praise: ‏Thanks for the clean up

dd-octo-sts · 2026-10-07T11:21:25Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-07T11:21:29Z

View all feedbacks in Devflow UI.

2026-10-07 11:21:28 UTC ℹ️ Start processing command /merge

2026-10-07 11:21:32 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-07 12:07:51 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 6d6f9ce:

test_debugger: [semeru8, 1/1]

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

dd-octo-sts · 2026-10-07T13:07:53Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-07T13:07:58Z

View all feedbacks in Devflow UI.

2026-10-07 13:07:58 UTC ℹ️ Start processing command /merge

2026-10-07 13:08:03 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-07 13:28:01 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 967a5b6:

create-multiarch-lib-injection-image

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

dd-octo-sts · 2026-10-07T15:55:33Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-07T15:55:37Z

View all feedbacks in Devflow UI.

2026-10-07 15:55:37 UTC ℹ️ Start processing command /merge

2026-10-07 15:55:41 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-07 16:14:18 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for f446714:

check_build_src

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

mcculls · 2026-10-07T17:44:05Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-07T17:44:09Z

View all feedbacks in Devflow UI.

2026-10-07 17:44:09 UTC ℹ️ Start processing command /merge

2026-10-07 17:44:13 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-07 18:01:37 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 31d257b:

check_build_src

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

mcculls · 2026-10-07T18:49:52Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-07T18:49:58Z

View all feedbacks in Devflow UI.

2026-10-07 18:49:57 UTC ℹ️ Start processing command /merge

2026-10-07 18:50:01 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-07 19:39:42 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 3be1f8d:

test_inst_latest: [25, 3/6]

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

mcculls · 2026-10-07T19:45:08Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-07T19:45:13Z

View all feedbacks in Devflow UI.

2026-10-07 19:45:12 UTC ℹ️ Start processing command /merge

2026-10-07 19:45:16 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-07 20:37:02 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 51c0bdb:

test_inst: [ibm8, 5/8]

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

mcculls · 2026-10-07T21:04:39Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-07T21:04:43Z

View all feedbacks in Devflow UI.

2026-10-07 21:04:42 UTC ℹ️ Start processing command /merge

2026-10-07 21:04:47 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-07 23:05:15 UTC ❌ MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 2225946521809688514 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

mcculls · 2026-10-08T00:17:50Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-10-08T00:17:55Z

View all feedbacks in Devflow UI.

2026-10-08 00:17:55 UTC ℹ️ Start processing command /merge

2026-10-08 00:17:59 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-10-08 01:23:51 UTC ℹ️ MergeQueue: This merge request was merged

mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Oct 5, 2026

This comment has been minimized.

Sign in to view

mcculls marked this pull request as ready for review October 5, 2026 22:16

mcculls requested a review from a team as a code owner October 5, 2026 22:16

mcculls requested review from sarahchen6 and removed request for a team October 5, 2026 22:16

sarahchen6 approved these changes Oct 5, 2026

View reviewed changes

datadog-datadog-prod-us1-2 Bot reviewed Oct 5, 2026

View reviewed changes

PerfectSlayer approved these changes Oct 6, 2026

View reviewed changes

Comment thread ...va-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/FieldBackedContextStores.java

mcculls added this pull request to the merge queue Oct 7, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 7, 2026

mcculls added this pull request to the merge queue Oct 7, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 7, 2026

Cleanup how we allocate context-store ids

fb6292c

mcculls force-pushed the mcculls/cleanup-context-store-allocation branch from e78675c to fb6292c Compare October 7, 2026 15:01

mcculls enabled auto-merge October 7, 2026 15:01

mcculls added this pull request to the merge queue Oct 7, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 7, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit 3eed707 into master Oct 8, 2026
608 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the mcculls/cleanup-context-store-allocation branch October 8, 2026 01:23

github-actions Bot added this to the 1.68.0 milestone Oct 8, 2026

Conversation

mcculls commented Oct 5, 2026

Motivation

Contributor Checklist

Uh oh!

This comment has been minimized.

dd-octo-sts Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

chatgpt-codex-connector Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

sarahchen6 left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1-2 Bot left a comment

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dd-octo-sts Bot commented Oct 7, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

Uh oh!

dd-octo-sts Bot commented Oct 7, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

Uh oh!

dd-octo-sts Bot commented Oct 7, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

Uh oh!

mcculls commented Oct 7, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

mcculls commented Oct 7, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

mcculls commented Oct 7, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

mcculls commented Oct 7, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcculls commented Oct 8, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

dd-octo-sts Bot commented Oct 5, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 5, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 7, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Oct 8, 2026 •

edited

Loading