Skip to content
This repository was archived by the owner on Sep 14, 2019. It is now read-only.
This repository was archived by the owner on Sep 14, 2019. It is now read-only.

Intake does not intake cubes after the first one #110

Open

Description

@brettle

Mackenzi, Alice, Josh and I noticed this at Maker Faire. We could intake one cube and eject it, but then could not intake a second cube (the wheels would not spin in the intake direction when pressing the associated button). The problem would go away if we restarted the code though, so it was clearly a code problem. My theory is that it thinks a cube is still in the intake even after it has been ejected.

Activity

  1. brettle commented on Jun 16, 2018

    @brettle
    MemberAuthor
  2. dfang314 commented on Sep 6, 2018

    @dfang314
    Contributor

    Resolved through latest DriverStationComputer commit.

  3. brettle commented on Sep 7, 2018

    @brettle
    MemberAuthor

    Why was this reopened?

  4. dfang314 commented on Sep 7, 2018

    @dfang314
    Contributor

    I assumed that we wanted to test in a competition environment to make sure it is resolved before we close it.

  5. brettle commented on Sep 8, 2018

    @brettle
    MemberAuthor

    If you were able to reliably reproduce the problem before the fix and attempts to reproduce the problem after the fix reliably failed, you should close the issue. If it comes up again in the future, we can always reopen it.

    As a side note, when closing an issue, it's best to mention the specific commit(s) which contain the fix so that they can be reviewed. For example, this bug was fixed by dccf8a7.

    Also, when writing the commit message, if you write #110 instead of "Issue 110", GitHub will make that a link to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions