You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 14, 2019. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 14, 2019. It is now read-only.
Intake does not intake cubes after the first one #110
Mackenzi, Alice, Josh and I noticed this at Maker Faire. We could intake one cube and eject it, but then could not intake a second cube (the wheels would not spin in the intake direction when pressing the associated button). The problem would go away if we restarted the code though, so it was clearly a code problem. My theory is that it thinks a cube is still in the intake even after it has been ejected.
If you were able to reliably reproduce the problem before the fix and attempts to reproduce the problem after the fix reliably failed, you should close the issue. If it comes up again in the future, we can always reopen it.
As a side note, when closing an issue, it's best to mention the specific commit(s) which contain the fix so that they can be reviewed. For example, this bug was fixed by dccf8a7.
Also, when writing the commit message, if you write #110 instead of "Issue 110", GitHub will make that a link to the issue.
Activity
brettle commentedon Jun 16, 2018
dfang314 commentedon Sep 6, 2018
Resolved through latest DriverStationComputer commit.
brettle commentedon Sep 7, 2018
Why was this reopened?
dfang314 commentedon Sep 7, 2018
I assumed that we wanted to test in a competition environment to make sure it is resolved before we close it.
brettle commentedon Sep 8, 2018
If you were able to reliably reproduce the problem before the fix and attempts to reproduce the problem after the fix reliably failed, you should close the issue. If it comes up again in the future, we can always reopen it.
As a side note, when closing an issue, it's best to mention the specific commit(s) which contain the fix so that they can be reviewed. For example, this bug was fixed by dccf8a7.
Also, when writing the commit message, if you write #110 instead of "Issue 110", GitHub will make that a link to the issue.