Skip to content

Add a smoothstep function to the math expression language - #4623

Merged
Keavon merged 2 commits into
masterfrom
math-parser-smoothstep
Sep 29, 2026
Merged

Keavon merged 2 commits into
masterfrom
math-parser-smoothstep

Conversation

@Keavon

@Keavon Keavon commented Sep 29, 2026

Copy link
Copy Markdown
Member

No description provided.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 5 files

Confidence score: 5/5

  • In libraries/math-parser/src/ast.rs, the OfValueAndRegions documentation does not explain that trailing holds the optional last value argument, which may confuse readers; update the field and variant docs to clarify its role.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="libraries/math-parser/src/ast.rs">

<violation number="1" location="libraries/math-parser/src/ast.rs:196">
P3: The new `trailing` field is undocumented, and the `OfValueAndRegions` doc comment still describes only "a value and regions" (`within(p, R)`). Readers can't tell this field holds the optional last value argument — e.g. `smoothstep(x, a..b, continuity)`'s continuity parameter — or when it is `Some`. Add a doc comment for the field and update the variant doc.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread libraries/math-parser/src/executer.rs Outdated
Comment thread libraries/math-parser/src/constants.rs
Comment thread libraries/math-parser/src/ast.rs
@Keavon
Keavon merged commit 68c3c75 into master Sep 29, 2026
10 checks passed
@Keavon
Keavon deleted the math-parser-smoothstep branch September 29, 2026 01:00

This branch was successfully deployed

1 active deployment
graphite-dev (Preview) — dd82abf9 Deployed Sep 29, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant