Add a smoothstep function to the math expression language - #4623
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Confidence score: 5/5
- In
libraries/math-parser/src/ast.rs, theOfValueAndRegionsdocumentation does not explain thattrailingholds the optional last value argument, which may confuse readers; update the field and variant docs to clarify its role.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="libraries/math-parser/src/ast.rs">
<violation number="1" location="libraries/math-parser/src/ast.rs:196">
P3: The new `trailing` field is undocumented, and the `OfValueAndRegions` doc comment still describes only "a value and regions" (`within(p, R)`). Readers can't tell this field holds the optional last value argument — e.g. `smoothstep(x, a..b, continuity)`'s continuity parameter — or when it is `Some`. Add a doc comment for the field and update the variant doc.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…trailing argument
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.