perf(ci): parallelize the clean-state suite too - #46
Merged
Merged
Conversation
clean-state was the last long CI job (~13m) after the test job dropped to ~2m with pytest-xdist. Its test selection is identical to the test job: no file list, and pyproject addopts keep `-m 'not slow and not benchmark'` (98 deselected). The same parallel run already passed on ubuntu+windows, so parallel safety is proven; locally it is 197s -> 71s (12 cores). The fresh venv, lockfile-drift gate (+ its negative control), the negative-controls inventory and the revision gate are all unchanged.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
clean-statewas the last long CI job (~13m25s) after thetestjob dropped to ~2m with pytest-xdist. It now runs the same suite with-n auto.Why this is safe (no quality loss)
clean-statepasses no file list and pyprojectaddoptskeep-m 'not slow and not benchmark'(98 deselected) — exactly the set thetestjob runs, which already passed in parallel on ubuntu+windows.clean-state(fresh environment, no file list so an ImportError in an unrelated file can't hide) is preserved.Measurement
Local (12 cores): serial 197s ->
-n auto71s; same1865 passed/0 failed. CI runners have 4 cores; the job should land around ~4m (tests ~2m + venv/install/gates).Trade-off (stated honestly)
clean-stateno longer provides an independent serial full-suite run. Parallel safety is already asserted by thetestjob on both OSes.