You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
blake2: implement CustomizedInit using digest macro #747
I'd like to take this. The two // TODO: impl in the macro impls in blake2/src/lib.rs can't move as-is, because the wrappers come from digest::buffer_ct_variable! and that macro has no impl: section, unlike buffer_fixed! and buffer_xof! which both already have a CustomizedInit arm.
So I've split it: RustCrypto/traits will add an optional trailing impl: ...; section to buffer_ct_variable! (purely additive, existing call forms untouched), and the blake2 side then becomes a two line change plus deleting the two hand-written impls. I have that follow-up ready locally and verified end to end against a patched digest, so I'll open it once the digest change lands and is released.
Activity
MavenRain commentedon Jul 31, 2026
I'd like to take this. The two
// TODO: impl in the macroimpls inblake2/src/lib.rscan't move as-is, because the wrappers come fromdigest::buffer_ct_variable!and that macro has noimpl:section, unlikebuffer_fixed!andbuffer_xof!which both already have aCustomizedInitarm.So I've split it: RustCrypto/traits will add an optional trailing
impl: ...;section tobuffer_ct_variable!(purely additive, existing call forms untouched), and the blake2 side then becomes a two line change plus deleting the two hand-written impls. I have that follow-up ready locally and verified end to end against a patched digest, so I'll open it once the digest change lands and is released.