fix: require solid-js 1.9.13 or later - #543
AlemTuzlak wants to merge 2 commits into
Conversation
The Solid compiler emits `use` from solid-js/web for every `ref`, and devtools-ui 0.7.0 added a ref to ThemeContextProvider. The server build of solid-js exported `use` only from 1.9.13, so SSR apps with solid-js 1.9.12 or earlier in their lockfile failed with `"use" is not exported`. The dependency and peer ranges were ">=1.9.7" and "^1.9.9", so resolvers kept the old versions. They now start at 1.9.13. The lockfile moves to solid-js 1.9.15 and no other package changes. 1.9.11+ also has the seroval security fix from #410. Fixes #511 Fixes #410
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: TanStack/devtools/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe pull request raises SolidJS dependency and peer dependency minimums to 1.9.13 across devtools packages and Solid examples. It adds a changeset marking five packages for patch releases. ChangesSolidJS version requirement
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to The change raises the SolidJS minimum to address the reported SSR startup failure. No specific blocking regression is evident in the reviewed changes. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 7 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit d2c6102
☁️ Nx Cloud last updated this comment at |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=test:eslint,test:sherif,t... |
❌ Failed | 4m 54s | View ↗ |
nx run-many --target=test:e2e --parallel=1 --pr... |
✅ Succeeded | 1m 16s | View ↗ |
nx run-many --targets=build --exclude=examples/... |
✅ Succeeded | 48s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-10-02 13:33:48 UTC
More templates
@tanstack/angular-devtools
@tanstack/devtools
@tanstack/devtools-a11y
@tanstack/devtools-bundler-core
@tanstack/devtools-client
@tanstack/devtools-rspack
@tanstack/devtools-ui
@tanstack/devtools-utils
@tanstack/devtools-vite
@tanstack/devtools-webmcp
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/preact-devtools
@tanstack/react-devtools
@tanstack/solid-devtools
@tanstack/svelte-devtools
@tanstack/vue-devtools
commit: |
sherif requires one range per dependency across the workspace. The examples and the Solid e2e app still asked for ^1.9.9. The lockfile already resolved them to 1.9.15, so only the specifiers change.

SSR apps with solid-js 1.9.12 or earlier in their lockfile cannot start the dev server:
"use" is not exported by solid-js/web/dist/server.js. This PR raises the solid-js minimum to 1.9.13, the first version whose server build exportsuse.🎯 Changes
usefromsolid-js/webfor everyref. Sincedevtools-ui0.7.0,ThemeContextProviderhas aref, anddevtoolsanddevtools-utilshave refs too.useto its server build (as anotSupstub) in 1.9.13. Our ranges were>=1.9.7and^1.9.9, so lockfiles with 1.9.12 stayed valid and then failed.devtools,devtools-ui,devtools-utils,devtools-a11y, andsolid-devtoolsnow start at1.9.13.^1.9.13, becausesherifrequires one range per dependency in the workspace.serovalsecurity fix that bump solid-js to avoid security vulnerability #410 asks for.✅ Checklist
pnpm test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Testing
Commands run
vitest runfordevtools-ui(64),devtools(370),devtools-utils(18), anddevtools-a11y(31): all pass on solid-js 1.9.15.pnpm install --frozen-lockfile: the lockfile is consistent.pnpm run test:sherif: no errors.packages/devtools-ui,solid-js/webresolves to the server build under Node, andtypeof useisfunction.pnpm test:pr.Manual test
solid-js@1.9.12in its lockfile and@tanstack/devtools@0.14.x.vite devfails withMISSING_EXPORT "use".vite devstarts.How this PR makes testing easy
No new tests. The existing Solid package suites now run on solid-js 1.9.15.
Linked issues
Fixes #511
Fixes #410
Risk / rollback
Low. Apps that pin solid-js below 1.9.13 get a peer warning and must update solid-js. To undo, revert this PR.
Public API change
Before
After
🤖 Generated with Claude Code
Summary by CodeRabbit