Repository navigation
Dev sprint ideas: More tests, type hints and less complexity #2128
Description
Activity
- addedenhancementThis PR modified some existing filesThis PR modified some existing files
on Jun 17, 2020 We push all new contributions to use type hints as discussed in CONTRIBUTING.md.
All efforts to add type hints to existing algorithms would be warmly received.We can use mypy for testing code
We do this already https://github.com/TheAlgorithms/Python/blob/master/.travis.yml#L17
Reacted by onlinejudge95, vinayak and Nayuki@cclauss How about a dev sprint kind of thing where we go about adding all such improvements?
Cool idea! Another thing (a sprint topic?) that is bugging me is code complexity which we currently set to 25 but I would be much happier to see it at 15. We would need to ensure that the files have strong type hints and tests before modifying them to reduce their cyclomatic complexity.
Reacted by vinayak and onlinejudge95Another cool sprint topic would be to add doctests to Python files that have <10% test coverage. Some files like file_transfer/send_file.py and the web programming files are difficult to write tests for but others should be fair game.
Reacted by onlinejudge95 and Fabrício Vilela- changed the title
[-]Static typing standard for repository[/-][+]Dev sprint ideas: More tests, type hints and less cyclomatic complexity[/+]on Jun 17, 2020 - changed the title
[-]Dev sprint ideas: More tests, type hints and less cyclomatic complexity[/-][+]Dev sprint ideas: More tests, type hints and less code complexity[/+]on Jun 17, 2020 - changed the title
[-]Dev sprint ideas: More tests, type hints and less code complexity[/-][+]Dev sprint ideas: More tests, type hints and less complexity[/+]on Jun 17, 2020 Should we have a short sprint or a long one? One idea would be 24 hour sprint — given that tomorrow is summer solstice (longest day of the year) — the sprint could start at midnight tonight (in whatever timezone the contributer is in) and last for 24 hours. #2128 could be our tracking issue for keeping track of tasks and accomplishments. Thoughts on this Summer Solstice Special Sprint idea.
Reacted by onlinejudge95 and vinayakSeems awesome, we can gain some attention by Summer Solstice Special Sprint, I am up on gitter if you want to discuss
23 remaining items
- added a commit that references this issue
on Oct 8, 2020 - added a commit that references this issue
on Oct 15, 2020 - added 9 commits that reference this issue
on Jan 3, 2021
currently, some of the programs use static type checking like this program but some of the programs did not use static typing.
it's a good practice to use static typing as it makes code more clear and readable, should we make it a standard for this repository.we can use mypy for testing code
more on static typing
thank you
Dev sprint ideas:
flake8 --max-complexity=15(Ensure files have strong tests before refactoring). Test results from WIP: Travis CI: Lower flake8 max-complexity to 15 #2139...