Repository navigation
Conversation
`AUX` is a reserved device name on Windows, and the restriction applies to a path segment's basename before its extension. Both the directory `src/generators/aux/` and the file `aux.ts` within it were therefore invalid paths, causing `git clone` to fail on Windows with "error: invalid path" and leaving the working tree unusable. Rename the directory to `auxiliary/` and the file to `auxiliary.ts`, and update the factory paths in `generators.json` plus the import in `compat.ts` to match. The generator is still registered under the name `aux`, so consumers continue to invoke it as `nx g angular-three-plugin:aux`. Only internal file paths change, so there is no public API impact. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ Deploy Preview for angularthreesoba ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for angularthreedemo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cloning this repository on Windows fails:
AUXis a reserved device name on Windows, and the restriction applies to a path segment's basename before its extension — so both the directorysrc/generators/aux/and the fileaux.tsinside it are invalid paths.The clone aborts partway through, leaving the working tree unusable. Windows contributors currently have to set
core.protectNTFS=falseto check the repo out at all, which is a workaround rather than a fix.Change
src/generators/aux/aux.tssrc/generators/auxiliary/auxiliary.tssrc/generators/aux/compat.tssrc/generators/auxiliary/compat.tssrc/generators/aux/schema.jsonsrc/generators/auxiliary/schema.jsonFactory/schema paths in
generators.jsonand the relative import incompat.tsare updated to match.No public API impact
The generator remains registered under the name
auxingenerators.json, so consumers invoke it exactly as before:Only internal file paths change. The
schematics(Angular CLI compat) entry is updated in lockstep.Validation
Performed on Windows with
core.protectNTFSat its default (true):auxiliary/aux.ts, confirming the file rename is required.nx build pluginpasses, anddist/containsauxiliary/auxiliary.js,compat.js, andschema.json.generators+ 4schematics) resolve from the built output: each factory loads and exports a callable default, and each schema parses as valid JSON.CON,PRN,AUX,NUL,COM0-9,LPT0-9) — none left.Note on
plugin:testmigrate-tweakpane.spec.tsfails via a 5s timeout, but this is pre-existing and unrelated — it fails identically on an unmodified checkout ofmain(the generator takes ~9-14s on Windows). Left untouched so as not to mix concerns into this PR.