"Private" isolated scope #10140

Activity

1. Narretz

   added

   resolution: duplicate

   on Nov 20, 2014
2. Narretz commented on Nov 20, 2014

   

   Narretz

   on Nov 20, 2014

   Contributor

   More actions

   I think this is the same as #5830
   However, a similar (the same?) idea called "localApply" was tested here #8055 and found to be too difficult to implement.
3. Narretz

   closed this as completedon Nov 20, 2014
4. kostat commented on Nov 20, 2014

   

   kostat

   on Nov 20, 2014

   Author

   More actions

   @Narretz: the issue you mention is almost the opposite of my suggestion! I'm talking about skipping a scope subtree during $digest, while #5830 proposes to limit $apply.

   The implementation is also relatively trivial:

   • Have a special collection of $$digestWatchers.
   • These watchers would behave exactly same as "normal" watchers except that if all of them are not dirty, the loop would not run the "normal" watchers neither for that scope, nor for its children.
   • "local" (internal) $applies will check the same after an internal $digest, whether any of 2-way $$digestWatchers is dirty and call the root's $apply
   • [I omit detailing of "private" child scopes $apply changes, but they are fairly trivial too]
   • During DDO $compilation $$digestWatchers will be initialized from the DDO's scope definition.

   If I had an assertion, that the contribution would be accepted provided it passes tests/quality standards, I can do it myself (I'm a large mono contributor in the past).

   P.S. I'd like also ask you to remove the resolution label.
5. Narretz

   added

   type: perf

   needs: investigation

   and removed

   resolution: duplicate

   on Nov 21, 2014
6. Narretz

   added this to the Ice Box milestone on Nov 21, 2014
7. Narretz commented on Nov 21, 2014

   

   Narretz

   on Nov 21, 2014

   Contributor

   More actions

   I've reopened it, but I can't evaluate the feasability of the change. In general, a PR as a more substantial starting point is always good, and perf improvements are always welcome.
8. Narretz

   reopened this on Nov 21, 2014
9. pkozlowski-opensource

   added

   component: $compile

   on Nov 23, 2014
10. kostat commented on Nov 26, 2014

    

    kostat

    on Nov 26, 2014

    Author

    More actions

    Created a relevant PR: #10221. My tests show reduce of watcher check by x3-x10.

    • There are additional optimizations that can be done in this area. I'll add more PRs when we progress with this one
11. Narretz commented on Jan 22, 2016

    

    Narretz

    on Jan 22, 2016

    Contributor

    More actions

    See #10221 (comment)
12. Narretz

    closed this as completedon Jan 22, 2016