Skip to content

refactor(language-service): create getTypeDefinitionAtPosition stubs - #39050

Closed
atscott wants to merge 1 commit into
angular:masterfrom
atscott:gettypedefinition
Closed

atscott wants to merge 1 commit into
angular:masterfrom
atscott:gettypedefinition

Conversation

@atscott

@atscott atscott commented Sep 29, 2020

Copy link
Copy Markdown
Contributor

Create stubs for getTypeDefinitionAtPosition for both VE and Ivy Language Service implementations.
This will prevent failed requests when it is implemented on the vscode plugin side

Create stubs for getTypeDefinitionAtPosition for both VE and Ivy Language Service implementations.
This will prevent failed requests when it is implemented on the vscode plugin side
@atscott atscott added action: review The PR is still awaiting reviews from at least one requested reviewer area: language-service Issues related to Angular's VS Code language service target: major This PR is targeted for the next major release labels Sep 29, 2020
@ngbot ngbot Bot modified the milestone: needsTriage Sep 29, 2020
@pullapprove
pullapprove Bot requested a review from ayazhafiz September 29, 2020 21:26
@kyliau kyliau added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 29, 2020
@alxhub alxhub closed this in 31e42f0 Sep 30, 2020
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants