Responsive API is not working with fxFlexFill #501

Activity

1. ThomasBurleson commented on Nov 28, 2017

   

   ThomasBurleson

   on Nov 28, 2017

   Contributor

   More actions

   fxFlexFill is currently only a static API; see here.
2. ThomasBurleson

   added

   bug

   docs

   enhancement

   P2Issue that is important to resolve as soon as possibleIssue that is important to resolve as soon as possible

   on Nov 28, 2017
3. ThomasBurleson

   added this to the Backlog milestone on Nov 28, 2017
4. CaerusKaru

   self-assigned this

   on Jan 12, 2018
5. CaerusKaru

   modified the milestones: Backlog, v5.0.0-rc.1This milestone has been deleted on Jan 12, 2018
6. CaerusKaru

   added

   in-progress

   question

   P5Low-priority issue that needs considerationLow-priority issue that needs consideration

   discussionFurther discussion with the team is needed before proceedingFurther discussion with the team is needed before proceeding

   and removed

   bug

   P2Issue that is important to resolve as soon as possibleIssue that is important to resolve as soon as possible

   in-progress

   on Jan 12, 2018
7. CaerusKaru

   modified the milestones: v5.0.0-beta.14, Backlog on Jan 20, 2018
8. CaerusKaru

   removed

   docs

   on Jan 20, 2018
9. CaerusKaru commented on Jan 20, 2018

   

   CaerusKaru

   on Jan 20, 2018

   Member

   More actions

   @ThomasBurleson Do you want to add a responsive API to this directive? If not, it should be closed since the docs have been updated to include this clarification.
10. CaerusKaru

    removed their assignment

    on Jan 20, 2018
11. mackelito commented on Mar 16, 2018

    

    mackelito

    on Mar 16, 2018

    More actions

    It would be a great addition.. right now we cant to have fxFlexFill only if fxLayout="column" and not fxLayout.gt-sm="row".. adding responsive features to fxFlexFill would make that super simple :)
12. CaerusKaru commented on Mar 16, 2018

    

    CaerusKaru

    on Mar 16, 2018

    Member

    More actions

    @mackelito This is probably something we could get in after beta.14 is validated, but if you wanted to throw together a PR sooner than that, I'd be happy to review it! 😄
13. matthewerwin commented on Apr 9, 2020

    

    matthewerwin

    on Apr 9, 2020

    Last edited by matthewerwin

    More actions

    @CaerusKaru this is an interesting issue b/c the library is quite constrained in this area. I was looking at issuing a PR as you solicited in 2018 since it's still not addressed. However, I think it's worth a bit of discussion on approach.

    Here is the criteria around this I can see:

    • Ability to fill horizontal-only(e.g. fxFillH.gt-lg), vertical-only (e.g. fxFillV.gt-lg), both (current behavior)
    • Allow user to specify a % that is used for width, height, max-width, max-height instead of default 100% on all these properties (e.g. fxFill.gt-lg="30%").

    Considerations:

    • How does this effect rendering if user adds fxFill, fxFillV, fxFillH to the same element to get predictable behavior? Perhaps fxFill checks for fxFillV & fxFillH...if either are active (based on BP)...then utilize those in fxFill...and in fxFillV, or fxFillH...if fxFill is present and active (based on BP) -- then do nothing since that will reference the %/px values if any in fxFillV, fxFillH
    • Add support to new layout system RFC.

    This would be very powerful in allowing very responsive handling of fill such as with SVG's. Let me know your thoughts.
14. CaerusKaru commented on Apr 9, 2020

    

    CaerusKaru

    on Apr 9, 2020

    Member

    More actions

    My preference for this would be to have it managed as an input. E.g. <h w> in percents. This would allow us to keep using one directive and maintain backwards-compatibility for current fxFill users.

    On a side note, please ping me on my personal email: (my GitHub alias separated by . at gmail dot com). We can discuss this as well as your cascading router PR on angular/angular.
15. CaerusKaru

    added

    help wantedThe team would appreciate a PR from the community to address this issueThe team would appreciate a PR from the community to address this issue

    feature

    and removed

    question

    on Jan 3, 2022