Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hides the server "Set as default" / "Remove default" menu items and the "Default" badge when only one server is registered. The default only affects startup selection and list ordering, both of which are no-ops with a single server, so the control was a confusing toy.
defaults.available()is the one gate every menu and badge already reads, so the count check lives there:Why it's a no-op with one server (the only readers of the stored key):
sortServerConnections– orders the default firstavailableStartupServer–defaultServer ?? "sidecar", resolves to the only server either wayServersProvider.defaultServer– accepted but unused ininitThe stored key is retained, so adding a second server later restores "Remove default" on the one that was already chosen.