Repository navigation
License: register third-party code missing from LICENSE - #2059
Merged
tuhaihe merged 2 commits intoOct 1, 2026
Merged
Conversation
pg_cron's bitstring.h carries the pre-4.4BSD form of the University of
California license, which asks that documentation and advertising
materials acknowledge UC Berkeley. Replace it with FreeBSD's
sys/sys/bitstring.h from stable/10, the same Berkeley code after UC
Berkeley deleted the advertising clause (FreeBSD commit 82c6e8799148).
That leaves it under the plain 3-clause BSD license, which RAT
recognizes, so drop its exclude.
The macros pg_cron uses (bit_decl, bit_set, bit_test, bit_nset and
bit_nclear) behave the same; the multi-statement ones are now wrapped
in do { } while (0).
Assisted-by: Claude Code
Add LICENSE entries, with the license texts under licenses/, for bundled code that LICENSE did not list: - pg_cron's copy of Vixie cron (entry.c, misc.c, cron.h) and Berkeley's bitstring.h (BSD-3). - From PostgreSQL: the Snowball stemmers and stop words (BSD-3), strftime.c (BSD-3), HyperLogLog (MIT), the IANA time zone code and data (public domain), and the Project X0213 and ICU mapping tables. - From Greenplum: cmockery (Apache-2.0). Exclude the two license texts that RAT does not recognize. This is the REL_2_STABLE version of the same change on main, which also covers pg_bsd_indent and LLVM's SectionMemoryManager; neither exists on this branch. Assisted-by: Claude Code
tuhaihe
force-pushed
the
license-register-missing-rel2
branch
from
September 29, 2026 09:53
8581f62 to
69ee0d8
Compare
tuhaihe
commented
Sep 29, 2026
Member
Author
|
After cherry-picking, we can merge this PR as an addition to the LICENSE compliance work. |
13 tasks
Member
Author
|
Similar PR for main: #2063 |
MisterRaindrop
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add LICENSE entries, with the license texts under licenses/, for bundled code that LICENSE did not list:
Exclude the three license texts that RAT does not recognize.
This is the REL_2_STABLE version of the same change on main, which also covers pg_bsd_indent and LLVM's SectionMemoryManager; neither exists on this branch.
Assisted-by: Claude Code
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions