Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
============================================
+ Coverage 86.54% 87.17% +0.62%
+ Complexity 9787 89 -9698
============================================
Files 532 499 -33
Lines 35516 33469 -2047
Branches 6194 5835 -359
============================================
- Hits 30738 29176 -1562
+ Misses 3518 3167 -351
+ Partials 1260 1126 -134 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SparseFieldMatrix computes its hash key as row * columns + column in int arithmetic, but unlike OpenMapRealMatrix its constructor never checks that the dimension product fits in an int, so a sparse matrix such as 100000 by 100000 is accepted and the key wraps for cells beyond the first 2^31. Two distinct cells can then share a key, for example setEntry(42950, 0) silently overwrites the value stored at (0, 32704), which seems worse than a failure since nothing signals the corruption. This adds the same NumberIsTooLargeException guard that MATH-679 gave OpenMapRealMatrix, along with a test that fails on master. AI tooling was used to help prepare this change.