branch-4.1: [fix](bitmap) fix SIGSEGV when reading zero-length serialized BITMAP/HLL/QuantileState cell #67473 - #68497
Merged
Conversation
…HLL/QuantileState cell (#67473) When a BITMAP / HLL / QUANTILE_STATE cell on disk has a serialized length of 0, ColumnComplexType::insert_binary_data used to interpret the raw page bytes as an in-memory value_type object via reinterpret_cast and then copy-assign it, which is undefined behavior. The heap-pointer members of BitmapValue / HyperLogLog / QuantileState were dereferenced as if they were valid pointers, and BE processes crashed with SIGSEGV during queries that hit read_by_rowids (e.g. lazy materialization on aggregate / unique-key tables that carry a BITMAP value column). Fix it by keeping the default-constructed empty object produced by insert_default() and returning early when length == 0. Add regression tests in be/test/core/column/column_complex_test.cpp covering all three complex types and all three code paths that flow into insert_binary_data.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
skip buildall |
yiguolei
approved these changes
Sep 25, 2026
Contributor
Author
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #67473