Repository navigation
Conversation
Collaborator
manner
reviewed
Oct 6, 2026
Comment on lines
+102
to
+108
| return new Tuple2<>("", CodeGenUtils.qualifyMethod(wholeDocument) + "(" + parsed + ")"); | ||
| } | ||
|
|
||
| final String pathSpec = operands.apply(1).literalValue().get().toString(); | ||
| final boolean isPathDefinite = SqlJsonUtils.isPathDefinite(pathSpec); | ||
| return new Tuple2<>( | ||
| parsed.parseCode, | ||
| "", |
Contributor
There was a problem hiding this comment.
Now that generateCallOnParsedInput() always returns "" as first param, you can remove the Tuple and change the return type to a plain string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
JSON_TYPE and JSON_LENGTH could return the previous row's result when an earlier JSON call on the same input was skipped (e.g. in
CASE WHEN). They now use the sharedJsonParseReuse, which parses on first use per record.Brief change log
JsonParseReuse, like the other JSON functionsgetOrCreateParsedJson) inJsonCodeGenUtils, which could leave stale parsed state for rows where the first JSON call was skippedVerifying this change
Added four tests to
JsonParseReuseTestcovering JSON_TYPE / JSON_LENGTH / JSON_VALUE on a shared input when the first call is skipped for some rows (CASE WHEN, short-circuitedORin a filter)Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: [Claude Opus 5.5]