fix(consensus): preserve recovery floors and reject aged-out requests - #4365
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4365 +/- ##
============================================
- Coverage 87.85% 87.21% -0.65%
- Complexity 1577 1578 +1
============================================
Files 1290 1289 -1
Lines 228844 224404 -4440
Branches 192194 187740 -4454
============================================
- Hits 201049 195710 -5339
- Misses 23071 23740 +669
- Partials 4724 4954 +230
🚀 New features to boost your workflow:
|
hubcio
force-pushed
the
fix/partition-recovery-and-old-requests
branch
from
October 1, 2026 16:09
c26d002 to
0d5b2b7
Compare
spetz
requested changes
Oct 1, 2026
hubcio
force-pushed
the
fix/partition-recovery-and-old-requests
branch
3 times, most recently
from
October 2, 2026 09:41
6cd7d49 to
ade6a01
Compare
Recovery below the creation view could install an empty primary behind acknowledged writes. A directory left by an unfinished delete was loaded as the next partition with the same ids, and a directory created during recovery could lose its parent entries on power loss. A Normal backup re-adopted a late duplicate StartView of its own view and truncated prepares it had acked. Aged-out IDs could receive false success, and so could writes of an HTTP session whose minted client id another node or boot had used. Use the creation view as a floor without certifying the log, preserve certified WAL history, and ignore a StartView below the committed prefix or one that a Normal replica's log already holds. A created.revision file ties a partition directory to its incarnation. An older incarnation's directory is deleted, and the partition probes as if it had none. A newer one waits for metadata. The file is written after the hierarchy is persisted and stays out of install backups. A per-boot nonce in minted client ids replaces the reseeded counter. Return RequestTooOld for aged-out IDs, map it over HTTP and in C#, and stop retries on it, because the outcome is unknown. In Java, a poll deadline during a routing retry keeps the non-admission result.
hubcio
force-pushed
the
fix/partition-recovery-and-old-requests
branch
from
October 2, 2026 11:24
ade6a01 to
97e4b0c
Compare
piotr-laserdata
approved these changes
Oct 2, 2026
spetz
approved these changes
Oct 2, 2026
mmodzelewski
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovery below the creation view could install an empty primary
behind acknowledged writes. A directory left by an unfinished delete
was loaded as the next partition with the same ids, and a directory
created during recovery could lose its parent entries on power loss.
A Normal backup re-adopted a late duplicate StartView of its own
view and truncated prepares it had acked. Aged-out IDs could receive
false success, and so could writes of an HTTP session whose minted
client id another node or boot had used.
Use the creation view as a floor without certifying the log,
preserve certified WAL history, and ignore a StartView below the
committed prefix or one that a Normal replica's log already holds.
A created.revision file ties a partition directory to its
incarnation. An older incarnation's directory is deleted, and the
partition probes as if it had none. A newer one waits for metadata.
The file is written after the hierarchy is persisted and stays out
of install backups. A per-boot nonce in minted client ids replaces
the reseeded counter. Return RequestTooOld for aged-out IDs, map it
over HTTP and in C#, and stop retries on it, because the outcome is
unknown. In Java, a poll deadline during a routing retry keeps the
non-admission result.