Repository navigation
Fix table rename on a DataNode that missed the pre-release - #18800
Merged
Merged
Conversation
…pre-release in RenameTableProcedure and never aware of the existence of new table
JackieTien97
requested changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A rename is pre-released to every DataNode (PRE_UPDATE_TABLE) before the ConfigNode
commits it. A DataNode that registers during that phase is not in the broadcast target
set — it is frozen when the propagator is built — but it does receive the later commit
release. Such a DataNode ends up in a wrong state:
commitUpdateTablefinds no pre-released entry for the new name, so it only logs"skip commit update ... because it has been handled" and returns.
The old name therefore stays in the cache as a usable table, and the new name is
reported as TABLE_NOT_EXISTS on that DataNode. It only heals on lease recovery or
restart.
Fix
DataNodeTableCache): on a commit that finds no pre-released entry andcarries an
oldName, repair the cache — drop the old name fromdatabaseTableMapandleave a
NonCommittableTsTableplaceholder for the new name. The placeholder routesthe next lookup of the new name into the existing lazy-fetch path, which pulls the
committed definition from the ConfigNode. A repeated commit is idempotent: while the
placeholder exists the commit returns at the
NonCommittableTsTablecheck, and aftera fetch has consumed it the repair skips re-marking a table that is already cached.
AbstractAlterOrDropTableProcedure): the commit release of a renameis now broadcast through
ClusterCachePropagator, the same delivery guarantee thepre-release already has.