Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maybeLeaveGroup()polls the network client right after sendingLeaveGroup, while the member state is still
PREPARING_REBALANCE. If aJoinGroup response of an in-flight rebalance is pending, that poll
processes it; when this member is elected leader,
onLeaderElected()waits for a metadata refresh with an unbounded timer. With brokers
unreachable,
close()never returns regardless of its timeout, andwakeup()cannot interrupt it sinceclose()disables wakeups.Reset the state to
UNJOINEDbefore polling, so the JoinGroup handlerdiscards the response instead of driving a rebalance for a member that
is leaving.
Added a test that delivers a leader-electing JoinGroup response during
the LeaveGroup poll with brokers backed off. It hangs on trunk and
passes with this change.
Co-Authored-By: Claude