KAFKA-21093: Ensure all ConfigProviders get closed before throwing exception - #23516
Open
lucliu1108 wants to merge 2 commits into
Open
lucliu1108 wants to merge 2 commits into
lucliu1108 wants to merge 2 commits into
Conversation
chia7712
reviewed
Sep 19, 2026
| if (!result.data().isEmpty()) { | ||
| resolvedOriginals.putAll(result.data()); | ||
| try { | ||
| if (!providers.isEmpty()) { |
Member
There was a problem hiding this comment.
Could we move the try-finally into this if block, so it only runs when providers is non-empty?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbstractConfig.instantiateConfigProviders: close already-createdproviders before rethrowing on
ClassNotFoundException; also close thein-flight provider on any
RuntimeExceptionfromconfigure(), sinceit wasn't added to the map yet.
AbstractConfig.resolveConfigVariables: move the provider close callinto a finally so it still runs if
ConfigTransformer.transform()throws.
Worker.initConfigTransformer/MirrorMakerConfig.transform: samefix as above for the provider-instantiation loops in Connect.
Plugins.newConverter/newInternalConverter/newHeaderConverter: close the plugin ifconfigure()throws; also 2same leaks, on
Converter/HeaderConverter.Reviewers: Chia-Ping Tsai chia7712@gmail.com