fix(predicate): export Like symbols - #391
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Exports paimon::Like so shared-library builds can resolve its vtable.
Changes:
- Includes visibility macros.
- Marks
LikewithPAIMON_EXPORT.
| File | Description |
|---|---|
src/paimon/common/predicate/like.h |
Exports Like across shared-library boundaries. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lxy-9602
reviewed
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Export a narrow
MatchStringfunction frompaimon_sharedand use it frompaimon_global_index_shared. The bitmap reader can evaluate LIKE predicates without exporting or referencing the internal polymorphicLikeclass hierarchy across shared libraries.Tests
PAIMON_BUILD_SHARED=ON.cmake --build build --target paimon_global_index_shared -j 8passed on the same environment.Like; this follow-up keeps that hierarchy internal.API and Format
No public header under
include/or storage format/protocol changes. The internal predicate helper is exported for cross-library use.Documentation
No documentation update needed.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-6)