Conversation
* Dropped `--format` and `--quiet` arguments as they depend on the structs defined in ContainerCommands. Supporting those requires larger refactor, which we can do later if it's really needed.
Code Coverage
|
Comment on lines
762
to
766
Contributor
There was a problem hiding this comment.
I don't think we should drop these.
| CommandGroup( | ||
| name: "Image", | ||
| subcommands: [ | ||
| BuildCommand.self, |
Contributor
There was a problem hiding this comment.
Where do the builder and build subcommands show up now? In their own section?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
All commits must be signed and verified. Pull requests containing unsigned or unverified commits cannot be built or merged. See the GitHub documentation for instructions.
For all but trivial fixes, make sure to first create a GitHub issue that concisely describes the bug or desired enhancement as justification for the change. Large PRs with no justifying issue will be closed.
BuilderStartfunction to ContainerBuild/Builder+Start.swiftloadContainerSystemConfigtoContainerAPIClientas keeping it inContainerCommandsintroduces a circular dependency when imported byContainerBuildlater.container-buildandcontainer-builderto CLI plugins (under Plugins/ContainerBuild and Plugins/ContainerBuilder)--formatand--quietflag incontainer builder listas those reside inContainerCommands. Importing those inContainerBuilderintroduces a circular dependency.Type of Change
Motivation and Context
[Why is this change needed?]
Testing