ICC Profile data gets lost after resizing #105

Activity

1. blueimp commented on Apr 28, 2020

   

   blueimp

   on Apr 28, 2020

   Last edited by blueimp

   Owner

   More actions

   Thanks for the report @thehappycoder.

   Can you provide a sample image?

   Have you tried increasing the possible header size via maxMetaDataSize?

   While this library does not parse ICC data, it should include all APPn and COMMENT markers (ICC data being one of them) in the image head (given a high enough maxMetaDataSize):
   

   JavaScript-Load-Image/js/load-image-meta.js

   Lines 105 to 141 in 4d83777

   	// Search for APPn (0xffeN) and COM (0xfffe) markers,
   	// which contain application-specific meta-data like
   	// Exif, ICC and IPTC data and text comments:
   	if (
   	(markerBytes >= 0xffe0 && markerBytes <= 0xffef) ||
   	markerBytes === 0xfffe
   	) {
   	// The marker bytes (2) are always followed by
   	// the length bytes (2), indicating the length of the
   	// marker segment, which includes the length bytes,
   	// but not the marker bytes, so we add 2:
   	markerLength = dataView.getUint16(offset + 2) + 2
   	if (offset + markerLength > dataView.byteLength) {
   	// eslint-disable-next-line no-console
   	console.log('Invalid meta data: Invalid segment size.')
   	break
   	}
   	parsers = loadImage.metaDataParsers.jpeg[markerBytes]
   	if (parsers && !options.disableMetaDataParsers) {
   	for (i = 0; i < parsers.length; i += 1) {
   	parsers[i].call(
   	that,
   	dataView,
   	offset,
   	markerLength,
   	data,
   	options
   	)
   	}
   	}
   	offset += markerLength
   	headLength = offset
   	} else {
   	// Not an APPn or COM marker, probably safe to
   	// assume that this is the end of the meta data
   	break
   	}

   In my tests, the ICC profile data from sample images (e.g. from http://regex.info/blog/photo-tech/color-spaces-page2) was still attached, but the color profile was not correctly applied anymore.
2. fleitnerfischer commented on Sep 29, 2022

   

   fleitnerfischer

   on Sep 29, 2022

   More actions

   Hi @blueimp, looks like the issue is still there?

   👍React with 👍2Reacted by Olivier Belzile and Leon
3. olivierbelzile commented on Oct 3, 2022

   

   olivierbelzile

   on Oct 3, 2022

   More actions

   I can confirm that from my test the issue is still there. The ICC profile is still included in the resized image but the color are wrong. To me it looks like the profile is applied twice rather than not. Maybe the solution is to drop the custom color profile from the resized image instead of trying to preserve it.