Skip to content

Refactor : replace BGL_FORALL_* macro with range-based in mcgregor_common_subgraphs.hpp - #618

Merged
Becheler merged 2 commits into
boostorg:developfrom
NNhanptnk:BGL_FORALL_-mcgregor_common_subgraphs_hpp
Oct 2, 2026
Merged

Becheler merged 2 commits into
boostorg:developfrom
NNhanptnk:BGL_FORALL_-mcgregor_common_subgraphs_hpp

Conversation

@NNhanptnk

@NNhanptnk NNhanptnk commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Before submitting

  • This PR targets the develop branch.
  • I searched for an existing PR or issue covering the same change.
  • My contribution is licensed under the Boost Software License 1.0.

Type of change

  • Bug fix
  • New feature or API addition
  • Refactor (no behavior change)
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

Does this PR introduce a breaking change?

  • Yes (describe migration impact below)
  • No

What this PR does

Like title, this PR is used to replace BGL_FORALL_* macro with range-based in a specific public header mcgregor_common_subgraphs.hpp

Motivation

Refactor pre-C++11 macro with range-based for loop.
This refactor only affects header : include/boost/graph/mcgregor_common_subgraphs.hpp
From #593

Testing

Checklist

  • Existing tests pass (b2 in the test/ directory).
  • New behavior is covered by a test, or this is a docs / build / refactor change.
  • Documentation was updated if user-facing behavior changed.
  • No new compiler warnings on the platforms I built against.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 36810977675 vs develop run 36743694638 (ef5d845696).

Header-inclusion weights (graph files pulling each direct dependency in):

Dependency develop PR Δ
range 7 8 +1

Transitive Boost modules: 47 → 47 (0)

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 36810977601 vs develop run 36743694380 (ef5d845696).

Job Baseline After Delta
macos (clang, 14) 392 392 0
macos (clang, 17) 391 391 0
macos (clang, 20) 391 391 0
ubuntu (clang-19, 14) 392 392 0
ubuntu (clang-19, 17) 391 391 0
ubuntu (clang-19, 20) 391 391 0
ubuntu (clang-19, 23) 391 391 0
ubuntu (gcc-14, 14) 345 345 0
ubuntu (gcc-14, 17) 341 341 0
ubuntu (gcc-14, 20) 341 341 0
ubuntu (gcc-14, 23) 341 341 0
windows_msvc_14_3 (msvc-14.3) 931 931 0

@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Becheler
Becheler merged commit 9a762a8 into boostorg:develop Oct 2, 2026
31 of 32 checks passed
@Becheler

Becheler commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

@NNhanptnk thank you! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants