Skip to content

Local identifier isn't used when calling Local.stop(); *all* instances of BrowserStackLocal are stopped. #34

Open

Description

@rlundy

When calling Local.stop() with a local identifier, this library doesn't appear to actually use the local identifier when stopping BrowserStackLocal. Consequently, if multiple BrowserStackLocal instances are running as daemons with different identifiers, all are stopped.

(Compare with using the executable, BrowserStackLocal.exe, with --daemon start. In that case, the local identifier is used, and only that instance is stopped. If the identifier is omitted, then all instances are stopped.)

Expected Behavior

If an identifier is provided, then calling Local.stop() should only stop any BrowserStackLocal instances with the corresponding identifier.

Actual Behavior

Even if an identifier is provided, calling Local.stop() stops all BrowserStackLocal instances without regard to their identifiers.

Activity

  1. bipul21 commented on Jan 17, 2019

    @bipul21
    Collaborator

    Hi,

    We are able to replicate this issue when you use the identifier like abcd and abcd1 and call .stop on one of them both the instances gets killed. The problem is in the BrowserStack Local Binary, we will fix the same in our next release and let you know here as well.

    In the meanwhile you can generate a unique identifer like uuid and use the same in which case it should work as expected.

    Apologies for the delay in responding here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions