You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 19, 2018. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 19, 2018. It is now read-only.
Rearrange the ambassadors page and implement the "main contact" role #425
Move the current ambassador above the list of countries
List the countries in a vertical list, smaller flags on the left of a clickable country name and expand/collapse the ambassadors for that country below it.
Implement the "role" field and the "main contact" flag in the DB so that the listing can take advantage of them.
However, the main ambassador's flag should be separate, I think. This would leave us to specify something else in the role field, if needed. I think that for the main ambassador, we can create a new group and use that as a "flag".
@michelesr Note that users are marked as ambassadors manually via the admin. The main contact flag will be set manually via the admin as well.
I am okay with the proposed model fields. Not sure why you'd prefer a boolean flag instead of a group for the main contact flag, but I'm okay with that as well--it was also my initial idea.
The only thing is that the role field seems a bit too long to me, we're not supposed to keep that much info there. Maybe up to 255 symbols would be fine, but I'm also okay with a limit of 1000.
The only thing is that the role field seems a bit too long to me, we're not supposed to keep that much info there. Maybe up to 255 symbols would be fine, but I'm also okay with a limit of 1000.
Yeah, that's was only an example, limit can be set to 255 i guess.
@michelesr Note that users are marked as ambassadors manually via the admin. The main contact flag will be set manually via the admin as well.
Activity
michelesr commentedon Sep 29, 2015
I inspected the model.
User profiles belonging to the group 'ambassadors' are the current ambassadors.
Maybe we can extend with a role field (blank for normal users) and add a proprerty that check if this field is == 'main contact'
mitio commentedon Sep 29, 2015
I also think we need a new free-text
rolefield.However, the main ambassador's flag should be separate, I think. This would leave us to specify something else in the
rolefield, if needed. I think that for the main ambassador, we can create a new group and use that as a "flag".michelesr commentedon Sep 29, 2015
I propose:
The check would be (in pseudocode):
Maybe the check can be avoided if we make sure that only ambassardors are able to subscribe as main contacts.
mitio commentedon Sep 29, 2015
@michelesr Note that users are marked as ambassadors manually via the admin. The main contact flag will be set manually via the admin as well.
I am okay with the proposed model fields. Not sure why you'd prefer a boolean flag instead of a group for the main contact flag, but I'm okay with that as well--it was also my initial idea.
The only thing is that the role field seems a bit too long to me, we're not supposed to keep that much info there. Maybe up to 255 symbols would be fine, but I'm also okay with a limit of 1000.
michelesr commentedon Sep 29, 2015
Yeah, that's was only an example, limit can be set to 255 i guess.
Good. I'll start the implementation soon.