Repository navigation
fix(changelog): include latest change when dry run and incremental - #1026
Merged
Merged
Conversation
woile
force-pushed
the
fix/1024-bump-changelog-incremental
branch
2 times, most recently
from
March 14, 2024 10:26
11747e2 to
d5dd019
Compare
woile
force-pushed
the
fix/1024-bump-changelog-incremental
branch
from
March 14, 2024 11:02
d5dd019 to
47762b6
Compare
Member
Author
|
@noirbizarre would this change be okay with you? One test for the hooks has changed a bit |
noirbizarre
approved these changes
Mar 14, 2024
noirbizarre
left a comment
Member
There was a problem hiding this comment.
Go on, LGTM to fix the issue.
I'll propose a refactoring later to have something more robust to handle changelog in bump command
This was referenced Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1024
Description
Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
Additional context