support config file #460

Activity

1. prometheas commented on May 28, 2018

   

   prometheas

   on May 28, 2018

   More actions

   I must first say that it's very courteous indeed that commitizen at least looks for its configs under a top-level config key in package.json, rather than forcing us to jam another bespoke key name in that file like so many other packages do, but… definitely this, please!
2. lucascono commented on Jan 28, 2019

   

   lucascono

   on Jan 28, 2019

   More actions

   Please, implement cosmiconfig. It is very useful to be able to highlight syntax in text editors according to file extensions.
3. Nargonath commented on Jun 19, 2019

   

   Nargonath

   on Jun 19, 2019

   More actions

   Another use case for this is when you want to gather all your configuration into one package ala react-scripts.
4. fsmaia commented on May 14, 2020

   

   fsmaia

   on May 14, 2020

   Last edited by fsmaia

   Contributor

   More actions

   I would love this too! Any help wanted?
5. travi commented on May 14, 2020

   

   travi

   on May 14, 2020

   Contributor

   More actions

   is there something special desired about cosmiconfig that isn't handled currently? i've been using .czrc files in my projects for quite a while. here are the currently supported sources:

   cz-cli/src/commitizen/configLoader.js

   Line 6 in a6adb3b

   var configs = ['.czrc', '.cz.json', 'package.json'];
6. Nargonath commented on May 14, 2020

   

   Nargonath

   on May 14, 2020

   More actions

   From what I remembered since my last post, what I wanted to do is "import" my configuration from a package instead of having it in the root folder i.e for prettier I can do that:

   // .prettierrc.js
   const config = require('my-prettier-config');
   
   module.exports = config;

   From what I understand such behavior was not possible at least in 2019 when I commented.
7. fsmaia commented on May 14, 2020

   

   fsmaia

   on May 14, 2020

   Contributor

   More actions

   I found out that the configuration is read in the presets/styles instead of cz-cli. Example:
   https://github.com/commitizen/cz-conventional-changelog/blob/master/index.js#L7
8. Nargonath commented on May 15, 2020

   

   Nargonath

   on May 15, 2020

   More actions

   I'm not sure what you mean by that.
9. fsmaia commented on May 15, 2020

   

   fsmaia

   on May 15, 2020

   Contributor

   More actions

   I mean that configLoader is used by cz-cli to determine the preset, but preset with additional configurations must also call configLoader to load them, otherwise rc file configurations won't be read.

   But IMHO this issue's main purpose is the lack of documentation concerning configuration files. A simple phrase in README like: "this project uses cosmiconfig" would be enough.

   👍React with 👍1Reacted by John Lianoglou
10. prometheas commented on May 19, 2020

    

    prometheas

    on May 19, 2020

    Last edited by prometheas

    More actions

    Yes, agree with @fsmaia that the heart of this issue is the lack of documentation around the package's support of config files, though it's hard to know without confirmation from its creator, @zyy7259.

    That said, assuming this is correct, the PR above (assuming it's approved and merged) does seem allow this issue to be closed…

    👍React with 👍1Reacted by Fernando Maia
11. LinusU

    closed this as completedin #739on Jul 6, 2020
12. commitizen-bot commented on Aug 21, 2020

    

    commitizen-bot

    on Aug 21, 2020

    More actions

    🎉 This issue has been resolved in version 4.1.3 🎉

    The release is available on:

    • npm package (@latest dist-tag)
    • GitHub release

    Your semantic-release bot 📦🚀
13. commitizen-bot

    added

    released

    on Aug 21, 2020
14. pmcelhaney commented on Jan 5, 2022

    

    pmcelhaney

    on Jan 5, 2022

    Contributor

    More actions

    For anyone following this thread I just created a PR to support cosmiconfig attached to #773

    🚀React with 🚀1Reacted by Fernando Maia