Repository navigation
chapter 4, service layer exercise, "decrement" should be "increment" in test names #48
Description
Activity
- changed the title
[-]Clarification for chapter 4, service layer exercies. [/-][+]Clarification for chapter 4, service layer exercise. [/+]on Jan 31, 2022 Hello Dmitry! thanks very much for these questions, it's nice to know someone is having a go at the exercises.
I've pushed some clarifications/explanations as TODOs in the exercise code, let me know what you think?
I've found exercises quite challenging so I think it fits quite nicely :)
Also, great job on the book, have enjoyed it. Right now trying to employ DDD techniques in my day job project 👍good luck! hey and if you have a couple of secs to write a review on amazon or goodreads or wherever you like to do that, it'd be much appreciated 😊
I'm having a question with the tests' names. As allocate decrements the available qunatity, should deallocate actually "increment" the available quantity?
oh yes! you're quite right sorry
- changed the title
[-]Clarification for chapter 4, service layer exercise. [/-][+]chapter 4, service layer exercise, "decrement" should be "increment" in test names[/+]on May 9, 2023
In chapter 4, we are challenged to implement a deallocation service, given a link with some stubs for tests and some complete e2e tests.
There are some inaccuracies with the exercies which I have found:
code/test_services.py
Line 58 in 7efebb6
Test uses unexistent service
add_batch. Shall we also implement it with tests? I would say yes. Maybe it worth to be included in the book itself?code/test_services.py
Line 59 in 7efebb6
Invalid call for a service.allocate() function.
Unclear cases:
code/test_services.py
Line 56 in 7efebb6
code/test_services.py
Line 67 in 7efebb6
What is an expected outcome of such functions? My intertpretation is that in first test we can deallocate any line with matching
orderidandskuwhich is allocated. In the second test we deallocate the line with matchingorderid,skuandqty. Is it correct?