Repository navigation
feat: health check method to DaprClient - #1815
Merged
Merged
Conversation
matheusandre1
marked this pull request as ready for review
September 24, 2026 17:06
javier-aliaga
approved these changes
Sep 28, 2026
matheusandre1
force-pushed
the
issue898
branch
from
September 28, 2026 13:47
26ba4f6 to
6306a25
Compare
javier-aliaga
requested changes
Sep 29, 2026
javier-aliaga
left a comment
Contributor
There was a problem hiding this comment.
It seems this pr is failing on java 25. @matheusandre1 can you take a look?
Signed-off-by: Matheus André <matheusandr2@gmail.com>
matheusandre1
force-pushed
the
issue898
branch
from
September 29, 2026 19:53
6306a25 to
1831569
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1815 +/- ##
============================================
+ Coverage 78.97% 78.99% +0.02%
- Complexity 2586 2591 +5
============================================
Files 264 264
Lines 7762 7770 +8
Branches 815 815
============================================
+ Hits 6130 6138 +8
Misses 1269 1269
Partials 363 363 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
javier-aliaga
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
healthCheck()method toDaprClientthat calls the sidecar's/v1.0/healthzendpoint, providing parity with the .NET SDK'sCheckHealthAsync.waitForSidecaralready uses/v1.0/healthz/outbound(done in add health check to wait for sidecar and test it #918), so apps can call Dapr APIs (e.g. read secrets) during startup without waiting for the app channel, which resolves the deadlock described in the issue./v1.0/healthz, which waits for all components, the Dapr HTTP port and the app channel to be ready (Health API docs)Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Closes: #898
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: