docs: fix contributor setup instructions in AGENTS.md - #1207
Open
saikishore-p wants to merge 2 commits into
Open
saikishore-p wants to merge 2 commits into
saikishore-p wants to merge 2 commits into
Conversation
`uv sync --all-packages --group dev` is not enough to run `tests/examples/` or `tests/integration/`. The `tests` group carries the extra dependencies those suites need - `examples/langgraph-checkpointer/agent.py` imports `langchain_ollama`, which only that group installs - and it is what CI syncs for both of those jobs (`.github/workflows/run-tests.yaml`). Following the setup section as written, `pytest tests/examples/` fails with a ModuleNotFoundError. Points the setup section at the `tests` group for those suites and names the requirement in the two command comments. Also corrects the pinned ruff version, which had drifted: AGENTS.md said 0.14.1 in two places while `pyproject.toml` pins `ruff==0.15.19`. Signed-off-by: Sai Kishore Punagani <63619246+saikishore-p@users.noreply.github.com>
CasperGN
requested changes
Sep 25, 2026
CasperGN
left a comment
Contributor
There was a problem hiding this comment.
Thanks, both fixes check out. langchain-ollama is only in the tests group, run-tests.yaml syncs --group tests for both jobs, and pyproject.toml pins ruff==0.15.19.
One change: README.md has the same gap. Its contributor steps sync --group dev (L116) and then run uv run pytest tests/integration/ and tests/examples/ (L142, L148), which fail the same way. Please apply the same fix there, so the two guides agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two fixes to the contributor instructions in
AGENTS.md.1. The setup command can't run two of the test suites.
The setup section says:
and the same document later says to run:
That combination fails.
examples/langgraph-checkpointer/agent.pyimportslangchain_ollama, which lives in thetestsdependency group, notdev:CI already gets this right — both the integration and example jobs in
.github/workflows/run-tests.yamlrunuv sync --frozen --all-packages --group tests.Only the contributor docs disagree. Since
testsincludesdevvia{include-group = "dev"}, pointing at it costs contributors nothing.This adds the
testsgroup to the setup section for those two suites, and names therequirement in the comments above the two commands that need it.
2. The pinned ruff version had drifted.
AGENTS.mdstates0.14.1in two places, whilepyproject.tomlpinsruff==0.15.19.Corrected to match the pin.
Issue reference
No issue — a documentation accuracy fix, found while setting up a dev environment
for #1206.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: