Repository navigation
Conversation
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
🟢 No issues found — LGTM! View logs.
glours
enabled auto-merge (rebase)
August 27, 2026 09:08
glours
disabled auto-merge
August 27, 2026 09:13
glours
requested changes
Aug 27, 2026
glours
left a comment
Contributor
There was a problem hiding this comment.
I missed this one during my first review
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
AGENTS.md covered build/test/lint mechanics but nothing about how the codebase is organized, so a reader's first mental model comes from file names and local comments — several of which used to be misleading (see the previous commits in this series). The new section states, in ~35 lines, the facts a contributor cannot derive from local reading: the two coexisting lifecycle engines and which commands use which (including that the plan never starts containers), the Run()/EventProcessor operation convention, the stdout/stderr split, the two environment-resolution idioms and the setEnvWithDotEnv timing, the config-hash label as the actual project membership invariant, and the Docker Desktop integration points that must fail silently. Part of docker#14074 (A: the code misdescribes its own structure). Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
a6-agents-architecture-map
branch
from
October 8, 2026 09:35
d2d17f9 to
db3ff2f
Compare
docker-agent
reviewed
Oct 8, 2026
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
| backend implementation (`NewComposeService`). Everything else under `pkg/` | ||
| is exported for historical reasons, not as a stability promise. | ||
| - **Two lifecycle engines coexist.** The plan-based reconciler | ||
| (`pkg/compose/reconcile.go`) has a single entry point: `create()` — so only |
Contributor
There was a problem hiding this comment.
[low] Parenthetical points to reconcile.go but create() lives in create.go
The text reads:
The plan-based reconciler (
pkg/compose/reconcile.go) has a single entry point:create()
The parenthetical (pkg/compose/reconcile.go) is most naturally read as the file where create() is defined — but composeService.create() is in pkg/compose/create.go, not in reconcile.go. The package-level reconciler function actually in reconcile.go is named reconcile().
A suggested rewording to avoid the confusion:
Suggested change
| (`pkg/compose/reconcile.go`) has a single entry point: `create()` — so only | |
| - **Two lifecycle engines coexist.** The plan-based reconciler (`pkg/compose/reconcile.go`, called via `composeService.create()` in `create.go`) has a single entry point: `create()` — so only |
| Confidence | Score |
|---|---|
| 🟡 moderate | 67/100 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENTS.md gains a ~35-line architecture map of the facts local reading cannot reveal: the two lifecycle engines and who calls which, the
Run()/events convention distinguishing exported operations from internal helpers, the stdout/stderr split, env-resolution idioms, the config-hash membership invariant, and Docker Desktop integration points.Note: references
service_containers.go, so best merged after #14129.Epic #14074, section A — split out of #14075 for focused review.
🤖 Generated with Claude Code