Migrate from flutter/material.dart to material_ui/material_ui.dart - #10016
Merged
Merged
Conversation
This applies the migration using dart fix: ``` dart fix --apply --code=migrate_design_widgets ```
johnpryan
requested review from
a team,
bkonyi,
kenzieschmoll and
srawlins
as code owners
September 22, 2026 18:55
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces imports of the official Flutter SDK libraries ('package:flutter/material.dart' and 'package:flutter/cupertino.dart') with untrusted external packages ('package:material_ui/material_ui.dart' and 'package:cupertino_ui/cupertino_ui.dart') across numerous files, and adds these external packages as dependencies in 'pubspec.yaml'. The reviewer correctly flagged these changes as critical security risks (potential supply chain attacks) and import violations, instructing to revert the dependency additions and restore the official Flutter SDK imports.
Explicitly apply theme text styles to MarkdownStyleSheet in SidePanel to fix dark theme contrast after migrating to package:material_ui. Also update the memory diff goldens to match the rendered upload icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the migration using dart fix:
This is the first step towards resolving #10015.