Skip to content

Clarify first-document creation - #153

Merged
MaggieAppleton merged 1 commit into
mainfrom
feat/148-document-creation
Sep 30, 2026
Merged

MaggieAppleton merged 1 commit into
mainfrom
feat/148-document-creation

Conversation

@Krzysztof-Cieslak

@Krzysztof-Cieslak Krzysztof-Cieslak commented Sep 10, 2026 •

Copy link
Copy Markdown
Member

Summary

Fixes #148.

  • Create in the current or sole writable project, with a dedicated project chooser and access guidance when needed.
  • Add an explicit first-document action, pencil tooltips, and visible creating/opening feedback on desktop and compact layouts.
  • Keep per-project creation guards through opening, retry existing documents after opening failures, and prevent late responses or competing landing redirects from taking over newer navigation.
  • Document the behavior and add browser regression coverage for first use, permissions, retries, overlapping requests, and focus.

Validation

  • 39 focused unit tests
  • 50 targeted Chromium tests across creation, document navigation, and hosted flows
  • Re-ran all 13 creation tests after the final empty-state adjustment
  • bun run types
  • bun run ci
  • Production web build
  • CI validation, full browser integration, and container build
  • Live preview creation/navigation smoke test (scope and limits below)

Review refresh — 30 September

Merged current main into this branch at 633f930a, preserving the newer tooltip and dialog changes. Added a documented 1 KB compressed JavaScript allowance for creation controls after the Linux build measured 80,886 bytes against the former 80,500-byte limit. Reviewed the creation behavior and renewed the two existing design boundary checksums.

Passed on the updated branch: 39 focused unit tests, 50 targeted Chromium tests, TypeScript checks, bun run ci, and the production build. The image below was captured from the updated local application with production authentication and navigation flows and fake GitHub responses. The live deployment smoke test below applies to the original commit. Updated the sidebar loading regression to check its specific loading status; all 9 interface-quality browser tests pass. The reviewed contents were folded into one commit on current main for the repository’s rebase-only merge policy; file contents are identical. Final review head: 7d380db3.

Live preview verification

Tested https://153-chopin.githubnext.com at 7a37d629f052a3b5753b96e2e10996e113d23744. The trusted deployment-ready timestamp followed PR creation, with no intervening push.

The restricted browser worker verified the configured dedicated test identity (CHOPIN_PREVIEW_GITHUB_USERNAME) and sole writable sandbox (CHOPIN_PREVIEW_REPOSITORY). Three empty sandbox documents were created within the approved scope.

Passed:

  • Empty project displays its explicit first-document action.
  • Global New document creates and opens the first document directly.
  • The project pencil creates and opens a second document.
  • Switching documents and reloading preserve the created documents.
  • Global creation works at 390×844; compact sidebar navigation and document controls remain reachable.

No application or interaction failures were observed, and no manual authentication step remains. The browser was restored to desktop size.

Limits: native tooltip display and transient creating/opening feedback were not observed with the restricted browser tools; pixel-level overflow/layout was not verifiable. Multi-project selection and forced delay/failure/race scenarios remain covered by local E2E rather than the single-sandbox live smoke test.

UI preview

Empty projects offer Create document; New document opens a dedicated chooser when multiple writable projects are available.

@coolify-githubnext-app

coolify-githubnext-app Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The preview deployment for chopin failed. 🔴

Open Build Logs | Open Application Logs

Last updated at: 2026-09-30 10:51:42 CET

@MaggieAppleton
MaggieAppleton merged commit 45e36b0 into main Sep 30, 2026
3 checks passed
@MaggieAppleton
MaggieAppleton deleted the feat/148-document-creation branch September 30, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing start after setup

2 participants