Clarify first-document creation - #153
Merged
Merged
Conversation
MaggieAppleton
force-pushed
the
feat/148-document-creation
branch
from
September 30, 2026 10:51
b92c0d4 to
bedab2d
Compare
|
The preview deployment for chopin failed. 🔴 Open Build Logs | Open Application Logs Last updated at: 2026-09-30 10:51:42 CET |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #148.
Validation
bun run typesbun run ciReview refresh — 30 September
Merged current
maininto this branch at633f930a, preserving the newer tooltip and dialog changes. Added a documented 1 KB compressed JavaScript allowance for creation controls after the Linux build measured 80,886 bytes against the former 80,500-byte limit. Reviewed the creation behavior and renewed the two existing design boundary checksums.Passed on the updated branch: 39 focused unit tests, 50 targeted Chromium tests, TypeScript checks,
bun run ci, and the production build. The image below was captured from the updated local application with production authentication and navigation flows and fake GitHub responses. The live deployment smoke test below applies to the original commit. Updated the sidebar loading regression to check its specific loading status; all 9 interface-quality browser tests pass. The reviewed contents were folded into one commit on currentmainfor the repository’s rebase-only merge policy; file contents are identical. Final review head:7d380db3.Live preview verification
Tested https://153-chopin.githubnext.com at
7a37d629f052a3b5753b96e2e10996e113d23744. The trusted deployment-ready timestamp followed PR creation, with no intervening push.The restricted browser worker verified the configured dedicated test identity (
CHOPIN_PREVIEW_GITHUB_USERNAME) and sole writable sandbox (CHOPIN_PREVIEW_REPOSITORY). Three empty sandbox documents were created within the approved scope.Passed:
No application or interaction failures were observed, and no manual authentication step remains. The browser was restored to desktop size.
Limits: native tooltip display and transient creating/opening feedback were not observed with the restricted browser tools; pixel-level overflow/layout was not verifiable. Multi-project selection and forced delay/failure/race scenarios remain covered by local E2E rather than the single-sandbox live smoke test.
UI preview