Repository navigation
Make tabs authorable in place and label empty table headers - #382
Conversation
|
Hold — please don't merge yet. Splitting the global table-width change out of this PR for a separate design decision, then a review. I'll post here when ready. 🤖 Generated with Claude Code |
|
Review: Looks good Checked in a worktree build against the fake server (headless Playwright, desktop 1440x900 and phone 390x844), plus code read. CI is green on all three jobs. Verified
Non-blocking findings
Keep the confirm once #352 (undo) lands? Keep it until #352 merges AND an e2e proves Cmd+Z restores a removed tab with its content. Then drop the arm step for tabs with content: immediate remove plus undo is cheaper than a two-step Delete and matches Linear/Vercel. Caveat: undo is per person, so a collaborator's removal still cannot be undone by you; if that matters, keep the confirm only when other people are present in the document. |
|
Hold lifted. |
|
Polish pushed in 6d100d5:
|
…th grid Tab labels rename on double-click or Enter, a quiet add button ends the strip, and tabs remove from a hover close button or Delete. A tab with content asks once before it goes, because document undo does not exist yet. The panel now ends on a hairline, and an empty one says what belongs there. Tables span the prose measure, and empty header cells read "Column 1", "Column 2" and so on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ip icons Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…op Backspace removal Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6d100d5 to
4a5c7ca
Compare
Why
/Tabsinserted tabs called "One" and "Two" that nobody could rename, add to or remove. The panel had no visible end, so its content ran into the next block./Tableinserted an unlabelled grid that stopped halfway across the page.What changed
Screenshots
Before: tabs, then a new table
After: new table, with header placeholders
After: phone, renaming by tap
Verification
bun run fix,bun run ci,bun run types, andbun run buildpassed.🤖 Generated with Claude Code