Fix record offsets when parsing a list of PAC records - #993
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PacRecord.list_from_bytesmoved to the next record by addinglen(bytes(record)), which is the length of the re-serialized record, not the number of bytes that were parsed.CodecSpecificCapabilities.__bytes__always writes all five LTVs, but Supported_Audio_Channel_Counts and Supported_Max_Codec_Frames_Per_SDU are optional and default to 1 when absent (BAP 4.3.1). A record without them is 6 bytes shorter than its re-serialized form, so every record after it in a Sink or Source PAC value (PACS Table 3.2 and 3.4) was parsed from the wrong offset. This affectsPublishedAudioCapabilitiesServiceProxy.sink_pacandsource_pac, used for example byapps/device_info.py.This adds
PacRecord.parse_from_bytes(data, offset), following theCodingFormat.parse_from_bytespattern, which returns the offset after the record, and uses it inlist_from_bytes.from_byteskeeps its behavior.Added
test_pac_record_listintests/profiles/bap_test.py, which parses two LC3 records that only carry the mandatory capabilities; it fails before the change (the second record is decoded starting 6 bytes too late and raisesUnboundLocalError) and passes after. Ran thetests/profilessuites, plus black, ruff, pylint and mypy on the touched files.