Skip to content

Fix APLR tag fallback and Windows static analysis - #686

Merged
paulbkoch merged 2 commits into
mainfrom
fix-aplr-inheritance
Oct 8, 2026
Merged

paulbkoch merged 2 commits into
mainfrom
fix-aplr-inheritance

Conversation

@paulbkoch

@paulbkoch paulbkoch commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The APLR inheritance reordering has already landed in #685. This PR retains the remaining fixes and regression coverage:

  • Preserve native APLR sklearn tags, falling back to InterpretML's mixin tags only when the native implementation returns None (including when sklearn is unavailable).
  • Add regression coverage for estimator inheritance order, native tag customizations, fallback tags, cloning, and parameter handling.
  • Select x64-hosted tools for scheduled Windows native analysis so MSBuild can locate clang-tidy on Visual Studio 2026 runners.

Validation

  • Targeted core/APLR tests: 86 passed, 43 skipped before merging main.
  • Reproduced the no-sklearn tag failure on main after Fix APLR wrappers' MRO with current aplr releases #685 and confirmed the PR fixes both APLR wrappers.
  • Verified MSBuild resolves and launches clang-tidy for both x64 and Win32 targets.
  • Full scheduled Windows static analysis was not completed locally.

paulbkoch and others added 2 commits October 7, 2026 17:23
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@paulbkoch paulbkoch changed the title Fix APLR inheritance order for versions with and without scikit-learn base classes Fix APLR tag fallback and Windows static analysis Oct 8, 2026
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.30%. Comparing base (ad09908) to head (8a0cca2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
+ Coverage   67.23%   67.30%   +0.07%     
==========================================
  Files          77       77              
  Lines       11735    11739       +4     
==========================================
+ Hits         7890     7901      +11     
+ Misses       3845     3838       -7     
Flag Coverage Δ
bdist_linux_311_python 67.05% <100.00%> (+0.10%) ⬆️
bdist_linux_312_python 67.05% <100.00%> (+0.10%) ⬆️
bdist_linux_313_python 67.05% <100.00%> (+0.10%) ⬆️
bdist_linux_314_python 66.96% <100.00%> (+0.10%) ⬆️
bdist_linuxarm_311_python 67.05% <100.00%> (+0.08%) ⬆️
bdist_linuxarm_312_python 67.05% <100.00%> (+0.07%) ⬆️
bdist_linuxarm_313_python 67.05% <100.00%> (+0.12%) ⬆️
bdist_linuxarm_314_python 66.98% <100.00%> (+0.08%) ⬆️
bdist_mac_311_python 67.22% <100.00%> (+0.08%) ⬆️
bdist_mac_312_python 67.22% <100.00%> (+0.12%) ⬆️
bdist_mac_313_python 67.22% <100.00%> (+0.10%) ⬆️
bdist_mac_314_python 67.11% <100.00%> (+0.07%) ⬆️
bdist_win_311_python 67.23% <100.00%> (+0.08%) ⬆️
bdist_win_312_python 67.22% <100.00%> (+0.08%) ⬆️
bdist_win_313_python 67.23% <100.00%> (+0.10%) ⬆️
bdist_win_314_python 67.14% <100.00%> (+0.10%) ⬆️
sdist_linux_311_python 67.00% <100.00%> (+0.07%) ⬆️
sdist_linux_312_python 66.97% <100.00%> (+0.07%) ⬆️
sdist_linux_313_python 67.00% <100.00%> (+0.08%) ⬆️
sdist_linux_314_python 66.92% <100.00%> (+0.09%) ⬆️
sdist_linuxarm_311_python 67.01% <100.00%> (+0.10%) ⬆️
sdist_linuxarm_312_python 66.98% <100.00%> (+0.05%) ⬆️
sdist_linuxarm_313_python 67.01% <100.00%> (+0.08%) ⬆️
sdist_linuxarm_314_python 66.92% <100.00%> (+0.10%) ⬆️
sdist_mac_311_python 67.11% <100.00%> (+0.08%) ⬆️
sdist_mac_312_python 67.13% <100.00%> (+0.10%) ⬆️
sdist_mac_313_python 67.10% <100.00%> (+0.05%) ⬆️
sdist_mac_314_python 67.02% <100.00%> (+0.07%) ⬆️
sdist_win_311_python 67.23% <100.00%> (+0.08%) ⬆️
sdist_win_312_python 67.23% <100.00%> (+0.10%) ⬆️
sdist_win_313_python 67.23% <100.00%> (+0.10%) ⬆️
sdist_win_314_python 67.12% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paulbkoch
paulbkoch merged commit ab0e2bb into main Oct 8, 2026
133 of 137 checks passed
@paulbkoch
paulbkoch deleted the fix-aplr-inheritance branch October 8, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant