Repository navigation
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests.
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pyproject.tomlenables--strict-markers, andtests/test_typing.pyuses@pytest.mark.mypy_testing. That marker is missing from the pytest markers list. The pytest-mypy-testing plugin registers it when the plugin is installed. Packagers often run the suite without that plugin. Collection then fails with'mypy_testing' not found in markers configuration option.Fix
Register
mypy_testingin the markers list, with a short description in the same form as the existing entries.Verification
Commands ran from the repo root in
.venvon Python 3.13.5 and pytest 9.1.1.Before the change, with pytest-mypy-testing uninstalled,
.venv/bin/python -m pytest tests/test_typing.pyexited 2. Collection reported'mypy_testing' not found in markers configuration option.Before the change, with pytest-mypy-testing 0.2.0 installed, the same command exited 0. 15 passed.
After the change, with the plugin uninstalled,
.venv/bin/python -m pytest tests/test_typing.pyexited 5. Pytest collected 0 tests and printed no marker error. Those functions are namedmypy_*, so they are test items only when the plugin is installed..venv/bin/python -m pytestexited 0. 695 passed, 1 skipped, 1 warning.After the change, with pytest-mypy-testing 0.2.0 installed,
.venv/bin/python -m pytest tests/test_typing.pyexited 0. 15 passed..venv/bin/python -m pytestexited 0. 710 passed, 1 skipped, 1 warning.pre-commit run --files pyproject.tomlpassed (check toml, codespell, sp-repo-review and the other applicable hooks; Python/Markdown hooks had no files to check).This change was prepared with AI assistance (Cursor CLI) and reviewed by me.
Fixes #889